Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: data source aws_vpclattice.service can't search on anything but Service Identifier #31864

Closed
nicoaws opened this issue Jun 9, 2023 · 4 comments · Fixed by #32177
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/vpclattice Issues and PRs that pertain to the vpclattice service.
Milestone

Comments

@nicoaws
Copy link

nicoaws commented Jun 9, 2023

Terraform Core Version

1.4.5.

AWS Provider Version

5.1.0

Affected Resource(s)

The datasource aws_vpclattice.service can't search for services other than by Service Identifier. This is pretty much useless unless the service itself has been created with TF.
In the case services are created with K8s httproute resources, we need to be able to search by name or tags (or - better - both).

Expected Behavior

See above

Actual Behavior

See above

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

None

Steps to Reproduce

None

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

@nicoaws nicoaws added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Jun 9, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. service/vpclattice Issues and PRs that pertain to the vpclattice service. and removed bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Jun 9, 2023
@exoego
Copy link
Contributor

exoego commented Jun 23, 2023

@nicoaws
Hi, I've opened a PR for this #32177
If you wish this to happen, please 👍 in the PR so maintainers prioritize review 🙏

@github-actions github-actions bot added this to the v5.11.0 milestone Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/vpclattice Issues and PRs that pertain to the vpclattice service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants