-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aws_ecr_repository data source's most_recent_image_tags attribute #31757
Fix aws_ecr_repository data source's most_recent_image_tags attribute #31757
Conversation
Community NoteVoting for Prioritization
For Submitters
|
fb8acb6
to
f0707ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @Mikopet 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccECRRepositoryDataSource_' PKG=ecr ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 2 -run=TestAccECRRepositoryDataSource_ -timeout 180m
=== RUN TestAccECRRepositoryDataSource_basic
=== PAUSE TestAccECRRepositoryDataSource_basic
=== RUN TestAccECRRepositoryDataSource_encryption
=== PAUSE TestAccECRRepositoryDataSource_encryption
=== RUN TestAccECRRepositoryDataSource_nonExistent
=== PAUSE TestAccECRRepositoryDataSource_nonExistent
=== CONT TestAccECRRepositoryDataSource_basic
=== CONT TestAccECRRepositoryDataSource_nonExistent
--- PASS: TestAccECRRepositoryDataSource_nonExistent (4.40s)
=== CONT TestAccECRRepositoryDataSource_encryption
--- PASS: TestAccECRRepositoryDataSource_basic (24.08s)
--- PASS: TestAccECRRepositoryDataSource_encryption (24.73s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ecr 34.399s
@Mikopet Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Just a quick fix for
most_recent_image_tags
inecr_repository
data source to give result with a single image in a repositoryOutput from Acceptance Testing