r/aws_transfer_server: Add support for TransferSecurityPolicy-2023-05

[trevorrea]

Description

This MR adds support for TransferSecurityPolicy-2023-05 to r/aws_transfer_server. See https://docs.aws.amazon.com/transfer/latest/userguide/security-policies.html#security-policy-transfer-2023-04

Relations

Closes #31531

References

#25060 - this is an MR to add support for a new security policy previously. I have copied it. Not sure if there are AWS SDK for Go requirements which need to be met as well.

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[trevorrea]

I had one job and managed to copy and paste and introduce a typo :) The tests should pass now..

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/SecurityPolicy' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/Server/SecurityPolicy -timeout 180m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/SecurityPolicy
--- PASS: TestAccTransfer_serial (218.08s)
    --- PASS: TestAccTransfer_serial/Server (218.08s)
        --- PASS: TestAccTransfer_serial/Server/SecurityPolicy (218.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	224.188s

[ewbankkit]

@trevorrea Thanks for the contribution 🎉 👏.

[SantiMunoz]

Hello, will this change be released on a 4.x version as well?
Thanks!

[trevorrea]

HI @SantiMunoz I'm not a Hashicorp employee but as far as I'm aware from what's happened in the past once a new major provider version is released no new functionality is added to the previous version. You can imagine the maintenance overhead if changes had to be constantly backported to 4.x from 5.x.

[github-actions]

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.