Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_rbin_rule: Fix multiple resource tag panic #31393

Merged
merged 3 commits into from
May 30, 2023
Merged

r/aws_rbin_rule: Fix multiple resource tag panic #31393

merged 3 commits into from
May 30, 2023

Conversation

dedunumax
Copy link
Contributor

@dedunumax dedunumax commented May 12, 2023

Description

aws-rbin_rule update crashes with multiple resource tags.

panic: interface conversion: interface {} is *schema.Set, not []interface {}

Steps to re-produce the panic.

resource "aws_rbin_rule" "example" {
  description   = "example_rule"
  resource_type = "EBS_SNAPSHOT"

  resource_tags {
    resource_tag_key   = "tag_key1"
    resource_tag_value = "tag_value1"
  }

  retention_period {
    retention_period_value = 10
    retention_period_unit  = "DAYS"
  }

  tags = {
    "test_tag_key" = "test_tag_value"
  }
}

Update the resource with two tags

resource "aws_rbin_rule" "example" {
  description   = "example_rule"
  resource_type = "EBS_SNAPSHOT"

  resource_tags {
    resource_tag_key   = "tag_key1"
    resource_tag_value = "tag_value1"
  }

  resource_tags {
    resource_tag_key   = "tag_key2"
    resource_tag_value = "tag_value2"
  }

  retention_period {
    retention_period_value = 10
    retention_period_unit  = "DAYS"
  }

  tags = {
    "test_tag_key" = "test_tag_value"
  }
}

Relations

Closes #0000

References

Output from Acceptance Testing

$ make testacc PKG=rbin TESTS=TestAccRBinRule_basic
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rbin/... -v -count 1 -parallel 20 -run='TestAccRBinRule_basic'  -timeout 180m
=== RUN   TestAccRBinRule_basic
=== PAUSE TestAccRBinRule_basic
=== CONT  TestAccRBinRule_basic
--- PASS: TestAccRBinRule_basic (52.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rbin	56.441s
$ make testacc PKG=rbin TESTS=TestAccRBinRule_disappears
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rbin/... -v -count 1 -parallel 20 -run='TestAccRBinRule_disappears'  -timeout 180m
=== RUN   TestAccRBinRule_disappears
=== PAUSE TestAccRBinRule_disappears
=== CONT  TestAccRBinRule_disappears
--- PASS: TestAccRBinRule_disappears (22.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rbin	25.872s
$ make testacc PKG=rbin TESTS=TestAccRBinRule_tags
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rbin/... -v -count 1 -parallel 20 -run='TestAccRBinRule_tags'  -timeout 180m
=== RUN   TestAccRBinRule_tags
=== PAUSE TestAccRBinRule_tags
=== CONT  TestAccRBinRule_tags
--- PASS: TestAccRBinRule_tags (70.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rbin	74.132s
$ make testacc PKG=rbin TESTS=TestAccRBinRule_lock_config
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rbin/... -v -count 1 -parallel 20 -run='TestAccRBinRule_lock_config'  -timeout 180m
=== RUN   TestAccRBinRule_lock_config
=== PAUSE TestAccRBinRule_lock_config
=== CONT  TestAccRBinRule_lock_config
--- PASS: TestAccRBinRule_lock_config (27.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rbin	31.107s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/rbin Issues and PRs that pertain to the rbin service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rbin Issues and PRs that pertain to the rbin service. labels May 12, 2023
@jar-b jar-b added service/rbin Issues and PRs that pertain to the rbin service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed needs-triage Waiting for first response or review from a maintainer. labels May 12, 2023
@dedunumax dedunumax marked this pull request as ready for review May 12, 2023 18:40
@dedunumax dedunumax changed the title Bt aws rbin rule multiple resource tag panic aws_rbin_rule: Fix multiple resource tag panic May 12, 2023
@dedunumax dedunumax changed the title aws_rbin_rule: Fix multiple resource tag panic r/aws_rbin_rule: Fix multiple resource tag panic May 12, 2023
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. labels May 19, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRBinRule_' PKG=rbin ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rbin/... -v -count 1 -parallel 3  -run=TestAccRBinRule_ -timeout 180m
=== RUN   TestAccRBinRule_basic
=== PAUSE TestAccRBinRule_basic
=== RUN   TestAccRBinRule_disappears
=== PAUSE TestAccRBinRule_disappears
=== RUN   TestAccRBinRule_tags
=== PAUSE TestAccRBinRule_tags
=== RUN   TestAccRBinRule_lock_config
=== PAUSE TestAccRBinRule_lock_config
=== CONT  TestAccRBinRule_basic
=== CONT  TestAccRBinRule_lock_config
=== CONT  TestAccRBinRule_tags
--- PASS: TestAccRBinRule_lock_config (18.06s)
=== CONT  TestAccRBinRule_disappears
--- PASS: TestAccRBinRule_disappears (15.52s)
--- PASS: TestAccRBinRule_basic (34.50s)
--- PASS: TestAccRBinRule_tags (45.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rbin	51.078s

@ewbankkit
Copy link
Contributor

@dedunumax Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit added this to the v5.1.0 milestone May 19, 2023
@ewbankkit ewbankkit merged commit fe48a07 into hashicorp:main May 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/rbin Issues and PRs that pertain to the rbin service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants