Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_autoscaling_traffic_attachment #31287

Closed
bryantbiggs opened this issue May 9, 2023 · 3 comments · Fixed by #31527
Closed

[Enhancement]: aws_autoscaling_traffic_attachment #31287

bryantbiggs opened this issue May 9, 2023 · 3 comments · Fixed by #31527
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Milestone

Comments

@bryantbiggs
Copy link
Contributor

Description

Add support for the Autoscaling attach-traffic-sources API

This change is composed of two aspects:

  1. Add a new resource aws_autoscaling_traffic_attachment
  2. Add the traffic_sources argument to the aws_autoscaling_group resource

Note: This could be considered for v5 changes to replace the existing aws_autoscaling_attachment. Copied from the CLI docs:

This API operation is superseded by AttachTrafficSources , which can attach multiple traffic sources types. We recommend using AttachTrafficSources to simplify how you manage traffic sources. However, we continue to support AttachLoadBalancerTargetGroups . You can use both the original AttachLoadBalancerTargetGroups API operation and AttachTrafficSources on the same Auto Scaling group.

However, since AWS still supports the existing attachment API/methods, this breaking, replacement change could be saved for a later v6+ change in the provider.

Affected Resource(s) and/or Data Source(s)

  • aws_autoscaling_traffic_attachment
  • aws_autoscaling_group

Potential Terraform Configuration

No response

References

Would you like to implement a fix?

None

@bryantbiggs bryantbiggs added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels May 9, 2023
@github-actions
Copy link

github-actions bot commented May 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/autoscaling Issues and PRs that pertain to the autoscaling service. label May 9, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 9, 2023
@github-actions github-actions bot added this to the v5.1.0 milestone May 31, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Projects
None yet
2 participants