Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_servicecatalog_provisioning_artifact: add provisioning_artifact_id attribute #31086

Merged
merged 2 commits into from
May 1, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented May 1, 2023

Description

Adds a computed provisioning_artifact_id for use with downstream resources accepting artifact IDs as inputs.

Relations

Closes #31053

Output from Acceptance Testing

$ make testacc PKG=servicecatalog TESTS=TestAccServiceCatalogProvisioningArtifact_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogProvisioningArtifact_'  -timeout 180m
=== RUN   TestAccServiceCatalogProvisioningArtifact_basic
=== PAUSE TestAccServiceCatalogProvisioningArtifact_basic
=== RUN   TestAccServiceCatalogProvisioningArtifact_disappears
=== PAUSE TestAccServiceCatalogProvisioningArtifact_disappears
=== RUN   TestAccServiceCatalogProvisioningArtifact_update
=== PAUSE TestAccServiceCatalogProvisioningArtifact_update
=== RUN   TestAccServiceCatalogProvisioningArtifact_physicalID
=== PAUSE TestAccServiceCatalogProvisioningArtifact_physicalID
=== CONT  TestAccServiceCatalogProvisioningArtifact_basic
=== CONT  TestAccServiceCatalogProvisioningArtifact_update
=== CONT  TestAccServiceCatalogProvisioningArtifact_physicalID
=== CONT  TestAccServiceCatalogProvisioningArtifact_disappears
--- PASS: TestAccServiceCatalogProvisioningArtifact_disappears (30.80s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_basic (37.26s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_update (60.91s)
--- PASS: TestAccServiceCatalogProvisioningArtifact_physicalID (61.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog     64.774s

@github-actions
Copy link

github-actions bot commented May 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 1, 2023
@jar-b jar-b merged commit ef61939 into main May 1, 2023
@jar-b jar-b deleted the f-provisioning-artifact-id branch May 1, 2023 15:15
@github-actions github-actions bot added this to the v4.66.0 milestone May 1, 2023
github-actions bot pushed a commit that referenced this pull request May 1, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

danielw-aws pushed a commit to danielw-aws/terraform-provider-aws that referenced this pull request May 31, 2023
…t_id` attribute (hashicorp#31086)

* r/aws_servicecatalog_provisioning_artifact: add provisioning_artifact_id attribute

* chore: changelog
danielw-aws pushed a commit to danielw-aws/terraform-provider-aws that referenced this pull request May 31, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: r/aws_servicecatalog_provisioning_artifact - Add provisioning_artifact_id attribute
1 participant