-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/glue_catalog_database - add tagging support #31071
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccGlueCatalogDatabase_' PKG=glue ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 2 -run=TestAccGlueCatalogDatabase_ -timeout 180m
=== RUN TestAccGlueCatalogDatabase_full
=== PAUSE TestAccGlueCatalogDatabase_full
=== RUN TestAccGlueCatalogDatabase_createTablePermission
=== PAUSE TestAccGlueCatalogDatabase_createTablePermission
=== RUN TestAccGlueCatalogDatabase_targetDatabase
=== PAUSE TestAccGlueCatalogDatabase_targetDatabase
=== RUN TestAccGlueCatalogDatabase_tags
=== PAUSE TestAccGlueCatalogDatabase_tags
=== RUN TestAccGlueCatalogDatabase_disappears
=== PAUSE TestAccGlueCatalogDatabase_disappears
=== CONT TestAccGlueCatalogDatabase_full
=== CONT TestAccGlueCatalogDatabase_disappears
--- PASS: TestAccGlueCatalogDatabase_disappears (13.58s)
=== CONT TestAccGlueCatalogDatabase_createTablePermission
--- PASS: TestAccGlueCatalogDatabase_full (42.65s)
=== CONT TestAccGlueCatalogDatabase_tags
--- PASS: TestAccGlueCatalogDatabase_createTablePermission (29.61s)
=== CONT TestAccGlueCatalogDatabase_targetDatabase
--- PASS: TestAccGlueCatalogDatabase_targetDatabase (32.19s)
--- PASS: TestAccGlueCatalogDatabase_tags (41.49s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/glue 89.619s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
References
Output from Acceptance Testing