Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_endpoint_configuration - add async_inference_config and s3_failure_path #31070

Merged
merged 4 commits into from
May 3, 2023

Conversation

DrFaust92
Copy link
Collaborator

Description

Relations

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccSageMakerEndpointConfiguration_ PKG=sagemaker

--- PASS: TestAccSageMakerEndpointConfiguration_async_kms (57.52s)
--- PASS: TestAccSageMakerEndpointConfiguration_shadowProductionVariants (59.72s)
--- PASS: TestAccSageMakerEndpointConfiguration_basic (61.30s)
--- PASS: TestAccSageMakerEndpointConfiguration_Async_client_failurePath (63.65s)
--- PASS: TestAccSageMakerEndpointConfiguration_nameGenerated (67.82s)
--- PASS: TestAccSageMakerEndpointConfiguration_async (68.90s)
--- PASS: TestAccSageMakerEndpointConfiguration_disappears (73.99s)
--- PASS: TestAccSageMakerEndpointConfiguration_Async_client (75.80s)
--- PASS: TestAccSageMakerEndpointConfiguration_Async_notif (77.01s)
--- PASS: TestAccSageMakerEndpointConfiguration_async_includeInference (79.24s)
--- PASS: TestAccSageMakerEndpointConfiguration_dataCapture (82.27s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType (82.72s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight (82.82s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_variantNameGenerated (85.02s)
--- PASS: TestAccSageMakerEndpointConfiguration_kmsKeyID (86.78s)
--- PASS: TestAccSageMakerEndpointConfiguration_upgradeToEnableSSMAccess (86.86s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless (90.10s)
--- PASS: TestAccSageMakerEndpointConfiguration_namePrefix (90.11s)
--- PASS: TestAccSageMakerEndpointConfiguration_tags (132.25s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 30, 2023
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 30, 2023
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. and removed enhancement Requests to existing resources that expand the functionality or scope. labels Apr 30, 2023
@DrFaust92 DrFaust92 marked this pull request as ready for review April 30, 2023 02:49
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 30, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSageMakerEndpointConfiguration_' PKG=sagemaker ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 2  -run=TestAccSageMakerEndpointConfiguration_ -timeout 180m
=== RUN   TestAccSageMakerEndpointConfiguration_basic
=== PAUSE TestAccSageMakerEndpointConfiguration_basic
=== RUN   TestAccSageMakerEndpointConfiguration_nameGenerated
=== PAUSE TestAccSageMakerEndpointConfiguration_nameGenerated
=== RUN   TestAccSageMakerEndpointConfiguration_namePrefix
=== PAUSE TestAccSageMakerEndpointConfiguration_namePrefix
=== RUN   TestAccSageMakerEndpointConfiguration_shadowProductionVariants
=== PAUSE TestAccSageMakerEndpointConfiguration_shadowProductionVariants
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_variantNameGenerated
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_variantNameGenerated
=== RUN   TestAccSageMakerEndpointConfiguration_kmsKeyID
=== PAUSE TestAccSageMakerEndpointConfiguration_kmsKeyID
=== RUN   TestAccSageMakerEndpointConfiguration_tags
=== PAUSE TestAccSageMakerEndpointConfiguration_tags
=== RUN   TestAccSageMakerEndpointConfiguration_dataCapture
=== PAUSE TestAccSageMakerEndpointConfiguration_dataCapture
=== RUN   TestAccSageMakerEndpointConfiguration_disappears
=== PAUSE TestAccSageMakerEndpointConfiguration_disappears
=== RUN   TestAccSageMakerEndpointConfiguration_async
=== PAUSE TestAccSageMakerEndpointConfiguration_async
=== RUN   TestAccSageMakerEndpointConfiguration_async_includeInference
=== PAUSE TestAccSageMakerEndpointConfiguration_async_includeInference
=== RUN   TestAccSageMakerEndpointConfiguration_async_kms
=== PAUSE TestAccSageMakerEndpointConfiguration_async_kms
=== RUN   TestAccSageMakerEndpointConfiguration_Async_notif
=== PAUSE TestAccSageMakerEndpointConfiguration_Async_notif
=== RUN   TestAccSageMakerEndpointConfiguration_Async_client
=== PAUSE TestAccSageMakerEndpointConfiguration_Async_client
=== RUN   TestAccSageMakerEndpointConfiguration_Async_client_failurePath
=== PAUSE TestAccSageMakerEndpointConfiguration_Async_client_failurePath
=== CONT  TestAccSageMakerEndpointConfiguration_basic
=== CONT  TestAccSageMakerEndpointConfiguration_dataCapture
--- PASS: TestAccSageMakerEndpointConfiguration_basic (29.66s)
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight
--- PASS: TestAccSageMakerEndpointConfiguration_dataCapture (37.50s)
=== CONT  TestAccSageMakerEndpointConfiguration_tags
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight (30.29s)
=== CONT  TestAccSageMakerEndpointConfiguration_kmsKeyID
--- PASS: TestAccSageMakerEndpointConfiguration_kmsKeyID (31.25s)
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_variantNameGenerated
--- PASS: TestAccSageMakerEndpointConfiguration_tags (58.05s)
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_variantNameGenerated (29.70s)
=== CONT  TestAccSageMakerEndpointConfiguration_Async_notif
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType (31.12s)
=== CONT  TestAccSageMakerEndpointConfiguration_Async_client_failurePath
--- PASS: TestAccSageMakerEndpointConfiguration_Async_notif (30.97s)
=== CONT  TestAccSageMakerEndpointConfiguration_Async_client
--- PASS: TestAccSageMakerEndpointConfiguration_Async_client_failurePath (30.37s)
=== CONT  TestAccSageMakerEndpointConfiguration_shadowProductionVariants
--- PASS: TestAccSageMakerEndpointConfiguration_Async_client (30.20s)
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless
--- PASS: TestAccSageMakerEndpointConfiguration_shadowProductionVariants (29.48s)
=== CONT  TestAccSageMakerEndpointConfiguration_async_includeInference
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless (30.43s)
=== CONT  TestAccSageMakerEndpointConfiguration_async_kms
--- PASS: TestAccSageMakerEndpointConfiguration_async_includeInference (32.52s)
=== CONT  TestAccSageMakerEndpointConfiguration_async
--- PASS: TestAccSageMakerEndpointConfiguration_async_kms (32.72s)
=== CONT  TestAccSageMakerEndpointConfiguration_disappears
--- PASS: TestAccSageMakerEndpointConfiguration_async (32.98s)
=== CONT  TestAccSageMakerEndpointConfiguration_namePrefix
--- PASS: TestAccSageMakerEndpointConfiguration_disappears (31.13s)
=== CONT  TestAccSageMakerEndpointConfiguration_nameGenerated
--- PASS: TestAccSageMakerEndpointConfiguration_namePrefix (29.61s)
--- PASS: TestAccSageMakerEndpointConfiguration_nameGenerated (28.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	310.945s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a2e93c5 into hashicorp:main May 3, 2023
@github-actions github-actions bot added this to the v4.66.0 milestone May 3, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants