Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rd/aws_autoscaling_group: add missing attributes #31067

Conversation

kamilturek
Copy link
Collaborator

@kamilturek kamilturek commented Apr 29, 2023

Description

This PR adds a handful of missing attributes listed in #20398 to the aws_autoscaling_group data source. For every attribute, strived to match the corresponding resource schema.

Attributes:

  • LaunchTemplate - added documentation (was already implemented)
  • EnabledMetrics - already done
  • MaxInstanceLifetime - added to the data source
  • MixedInstancesPolicy - added to the data source
  • PredictedCapacity - added to both data source and resource
  • SuspendedProcesses - added to the data source
  • Tags - added to the data source (in a way matching the implementation from the resource)
  • TerminationPolicies - already done
  • WarmPoolConfiguration - added to the data source
  • WarmPoolSize - added to both data source and resource

Relations

Closes #20398.

References

https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_DescribeAutoScalingGroups.html
https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_AutoScalingGroup.html
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/autoscaling_group

Output from Acceptance Testing

$ make testacc TESTARGS="-run=TestAccAutoScalingGroupDataSource_" PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingGroupDataSource_ -timeout 180m
=== RUN   TestAccAutoScalingGroupDataSource_basic
=== PAUSE TestAccAutoScalingGroupDataSource_basic
=== RUN   TestAccAutoScalingGroupDataSource_launchTemplate
=== PAUSE TestAccAutoScalingGroupDataSource_launchTemplate
=== RUN   TestAccAutoScalingGroupDataSource_mixedInstancesPolicy
=== PAUSE TestAccAutoScalingGroupDataSource_mixedInstancesPolicy
=== RUN   TestAccAutoScalingGroupDataSource_warmPool
=== PAUSE TestAccAutoScalingGroupDataSource_warmPool
=== RUN   TestAccAutoScalingGroupDataSource_tags
=== PAUSE TestAccAutoScalingGroupDataSource_tags
=== CONT  TestAccAutoScalingGroupDataSource_basic
=== CONT  TestAccAutoScalingGroupDataSource_warmPool
--- PASS: TestAccAutoScalingGroupDataSource_basic (46.31s)
=== CONT  TestAccAutoScalingGroupDataSource_tags
--- PASS: TestAccAutoScalingGroupDataSource_tags (45.48s)
=== CONT  TestAccAutoScalingGroupDataSource_mixedInstancesPolicy
--- PASS: TestAccAutoScalingGroupDataSource_mixedInstancesPolicy (36.77s)
=== CONT  TestAccAutoScalingGroupDataSource_launchTemplate
--- PASS: TestAccAutoScalingGroupDataSource_launchTemplate (36.74s)
--- PASS: TestAccAutoScalingGroupDataSource_warmPool (411.40s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        413.567s
$ make testacc TESTARGS="-run=TestAccAutoScalingGroup_basic" PKG=autoscaling ACCTEST_PARALLELISM=2          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingGroup_basic -timeout 180m
=== RUN   TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== CONT  TestAccAutoScalingGroup_basic
--- PASS: TestAccAutoScalingGroup_basic (48.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling        50.561s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Apr 29, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 29, 2023
@kamilturek kamilturek marked this pull request as ready for review April 29, 2023 15:10
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 1, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAutoScalingGroupDataSource_\|TestAccAutoScalingGroup_basic$$' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2  -run=TestAccAutoScalingGroupDataSource_\|TestAccAutoScalingGroup_basic$ -timeout 180m
=== RUN   TestAccAutoScalingGroupDataSource_basic
=== PAUSE TestAccAutoScalingGroupDataSource_basic
=== RUN   TestAccAutoScalingGroupDataSource_launchTemplate
=== PAUSE TestAccAutoScalingGroupDataSource_launchTemplate
=== RUN   TestAccAutoScalingGroupDataSource_mixedInstancesPolicy
=== PAUSE TestAccAutoScalingGroupDataSource_mixedInstancesPolicy
=== RUN   TestAccAutoScalingGroupDataSource_warmPool
=== PAUSE TestAccAutoScalingGroupDataSource_warmPool
=== RUN   TestAccAutoScalingGroupDataSource_tags
=== PAUSE TestAccAutoScalingGroupDataSource_tags
=== RUN   TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== CONT  TestAccAutoScalingGroupDataSource_basic
=== CONT  TestAccAutoScalingGroupDataSource_warmPool
--- PASS: TestAccAutoScalingGroupDataSource_basic (38.73s)
=== CONT  TestAccAutoScalingGroup_basic
--- PASS: TestAccAutoScalingGroup_basic (49.82s)
=== CONT  TestAccAutoScalingGroupDataSource_tags
--- PASS: TestAccAutoScalingGroupDataSource_tags (38.19s)
=== CONT  TestAccAutoScalingGroupDataSource_mixedInstancesPolicy
--- PASS: TestAccAutoScalingGroupDataSource_mixedInstancesPolicy (37.27s)
=== CONT  TestAccAutoScalingGroupDataSource_launchTemplate
--- PASS: TestAccAutoScalingGroupDataSource_launchTemplate (46.70s)
--- PASS: TestAccAutoScalingGroupDataSource_warmPool (352.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	360.160s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 736d107 into hashicorp:main May 3, 2023
@github-actions github-actions bot added this to the v4.66.0 milestone May 3, 2023
@kamilturek kamilturek deleted the f-data-aws-autoscaling-group-missing-attributes branch May 5, 2023 07:59
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data/aws_autoscaling_group - Update available fields
3 participants