-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rd/aws_autoscaling_group: add missing attributes #31067
rd/aws_autoscaling_group: add missing attributes #31067
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAutoScalingGroupDataSource_\|TestAccAutoScalingGroup_basic$$' PKG=autoscaling ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 2 -run=TestAccAutoScalingGroupDataSource_\|TestAccAutoScalingGroup_basic$ -timeout 180m
=== RUN TestAccAutoScalingGroupDataSource_basic
=== PAUSE TestAccAutoScalingGroupDataSource_basic
=== RUN TestAccAutoScalingGroupDataSource_launchTemplate
=== PAUSE TestAccAutoScalingGroupDataSource_launchTemplate
=== RUN TestAccAutoScalingGroupDataSource_mixedInstancesPolicy
=== PAUSE TestAccAutoScalingGroupDataSource_mixedInstancesPolicy
=== RUN TestAccAutoScalingGroupDataSource_warmPool
=== PAUSE TestAccAutoScalingGroupDataSource_warmPool
=== RUN TestAccAutoScalingGroupDataSource_tags
=== PAUSE TestAccAutoScalingGroupDataSource_tags
=== RUN TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== CONT TestAccAutoScalingGroupDataSource_basic
=== CONT TestAccAutoScalingGroupDataSource_warmPool
--- PASS: TestAccAutoScalingGroupDataSource_basic (38.73s)
=== CONT TestAccAutoScalingGroup_basic
--- PASS: TestAccAutoScalingGroup_basic (49.82s)
=== CONT TestAccAutoScalingGroupDataSource_tags
--- PASS: TestAccAutoScalingGroupDataSource_tags (38.19s)
=== CONT TestAccAutoScalingGroupDataSource_mixedInstancesPolicy
--- PASS: TestAccAutoScalingGroupDataSource_mixedInstancesPolicy (37.27s)
=== CONT TestAccAutoScalingGroupDataSource_launchTemplate
--- PASS: TestAccAutoScalingGroupDataSource_launchTemplate (46.70s)
--- PASS: TestAccAutoScalingGroupDataSource_warmPool (352.83s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 360.160s
@kamilturek Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds a handful of missing attributes listed in #20398 to the
aws_autoscaling_group
data source. For every attribute, strived to match the corresponding resource schema.Attributes:
LaunchTemplate
- added documentation (was already implemented)EnabledMetrics
- already doneMaxInstanceLifetime
- added to the data sourceMixedInstancesPolicy
- added to the data sourcePredictedCapacity
- added to both data source and resourceSuspendedProcesses
- added to the data sourceTags
- added to the data source (in a way matching the implementation from the resource)TerminationPolicies
- already doneWarmPoolConfiguration
- added to the data sourceWarmPoolSize
- added to both data source and resourceRelations
Closes #20398.
References
https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_DescribeAutoScalingGroups.html
https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_AutoScalingGroup.html
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/autoscaling_group
Output from Acceptance Testing