Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws_redshift_scheduled_action naming allowing non [0-9a-z-]{1,63} #31020

Merged
merged 3 commits into from
May 4, 2023

Conversation

dscain
Copy link
Contributor

@dscain dscain commented Apr 27, 2023

Description

When creating a resource "aws_redshift_scheduled_action", the name is allowed to have any content until it reaches AWS, where upon it may be rejected due to restrictions on scheduled actions. According to AWS official documentation, there is no restriction however the API will reject non [0-9a-z-]{1,63} strings, as explained in the Redshift Schedule Action console.

References

https://docs.aws.amazon.com/cli/latest/reference/application-autoscaling/put-scheduled-action.html

Output from Acceptance Testing

$ make testacc ACCTEST_PARALLELISM=1 TESTS=TestAccRedshiftScheduledAction_validScheduleName PKG=redshift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 1 -run='TestAccRedshiftScheduledAction_validScheduleName'  -timeout 180m
=== RUN   TestAccRedshiftScheduledAction_validScheduleName
=== PAUSE TestAccRedshiftScheduledAction_validScheduleName
=== CONT  TestAccRedshiftScheduledAction_validScheduleName
--- PASS: TestAccRedshiftScheduledAction_validScheduleName (0.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/redshift   0.391s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/redshift Issues and PRs that pertain to the redshift service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Apr 27, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @dscain 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 27, 2023
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed bug Addresses a defect in current functionality. labels May 4, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRedshiftScheduledAction_basicPauseCluster$$' PKG=redshift
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 20  -run=TestAccRedshiftScheduledAction_basicPauseCluster$ -timeout 180m
=== RUN   TestAccRedshiftScheduledAction_basicPauseCluster
=== PAUSE TestAccRedshiftScheduledAction_basicPauseCluster
=== CONT  TestAccRedshiftScheduledAction_basicPauseCluster
--- PASS: TestAccRedshiftScheduledAction_basicPauseCluster (37.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	43.041s

@ewbankkit
Copy link
Contributor

@dscain Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 8fdcc50 into hashicorp:main May 4, 2023
@github-actions github-actions bot added this to the v4.66.0 milestone May 4, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/redshift Issues and PRs that pertain to the redshift service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants