Enhancement: add configurable timeouts to r/aws_rds_cluster_role_association

[tamiros]

Description

Added configurable timeouts for the resource aws_rds_cluster_role_association.

The default for Create and Delete operations is still 10 minutes (there is no Update operation for the resource).

Also, omitted the backup_retention_period and preferred_backup_window which caused the acceptance test TestAccRDSClusterRoleAssociation_basic to try and delete the associated IAM Role while the cluster was in "backing-up" state:

make testacc TESTS='TestAccRDSClusterRoleAssociation_basic' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSClusterRoleAssociation_basic'  -timeout 180m
=== RUN   TestAccRDSClusterRoleAssociation_basic
=== PAUSE TestAccRDSClusterRoleAssociation_basic
=== CONT  TestAccRDSClusterRoleAssociation_basic
    testing_new.go:82: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting RDS DB Cluster (tf-acc-test-5773960513133025280) IAM Role (arn:aws:iam::531706124245:role/tf-acc-test-5773960513133025280) Association: InvalidDBClusterStateFault: DB Cluster tf-acc-test-5773960513133025280 is not available for IAM role association, disassociation, or updates. Current DB cluster status: backing-up
                status code: 400, request id: 5ccb4373-8b44-4445-b5dc-0ebc1faa9788
        
--- FAIL: TestAccRDSClusterRoleAssociation_basic (107.70s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/rds        107.773s
FAIL
make: *** [GNUmakefile:335: testacc] Error 1

Now the cluster resource itself in that particular acceptance test matches the one in the test testAccClusterConfig_basic in the file cluster_test.go.

Relations

Closes #30868

References

Output from Acceptance Testing

make testacc TESTS='TestAccRDSClusterRoleAssociation_basic' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20 -run='TestAccRDSClusterRoleAssociation_basic'  -timeout 180m
=== RUN   TestAccRDSClusterRoleAssociation_basic
=== PAUSE TestAccRDSClusterRoleAssociation_basic
=== CONT  TestAccRDSClusterRoleAssociation_basic
--- PASS: TestAccRDSClusterRoleAssociation_basic (209.54s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rds        209.607s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSClusterRoleAssociation_basic$$' PKG=rds
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSClusterRoleAssociation_basic$ -timeout 180m
=== RUN   TestAccRDSClusterRoleAssociation_basic
=== PAUSE TestAccRDSClusterRoleAssociation_basic
=== CONT  TestAccRDSClusterRoleAssociation_basic
--- PASS: TestAccRDSClusterRoleAssociation_basic (254.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	259.886s

[ewbankkit]

@tamiros Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.