Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_elasticache_user resource customizable timeouts #30921

Closed
AdrianFarmadin opened this issue Apr 25, 2023 · 5 comments · Fixed by #31076
Closed

[Enhancement]: aws_elasticache_user resource customizable timeouts #30921

AdrianFarmadin opened this issue Apr 25, 2023 · 5 comments · Fixed by #31076
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/elasticache Issues and PRs that pertain to the elasticache service. timeouts Pertains to timeout increases.
Milestone

Comments

@AdrianFarmadin
Copy link

Description

The aws_elasticache_user resource has hard-coded 5min timeouts. The user create step can take longer than 5min. It would be great to have an option to increase the timeout with Terraform customizable timeouts.

Affected Resource(s) and/or Data Source(s)

  • aws_elasticache_user

Potential Terraform Configuration

No response

References

Terraform documentation: https://developer.hashicorp.com/terraform/plugin/sdkv2/resources/retries-and-customizable-timeouts

Would you like to implement a fix?

None

@AdrianFarmadin AdrianFarmadin added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Apr 25, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/elasticache Issues and PRs that pertain to the elasticache service. label Apr 25, 2023
@justinretzolk justinretzolk added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. timeouts Pertains to timeout increases. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 25, 2023
@jbiers
Copy link

jbiers commented Apr 30, 2023

I would like to contribute to this issue @AdrianFarmadin

@hernandanielg
Copy link

Created a PR #31076 but still needs work, but if you can review it and point out what I could be missing or if it's going in the right direction would be amazing ;)

scaler-create-impact

@jbiers I'm sorry I was working on this few days ago but got distracted by real life (kids and wifey), hope you don't mind ✌🏻

@github-actions github-actions bot added this to the v4.66.0 milestone May 3, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/elasticache Issues and PRs that pertain to the elasticache service. timeouts Pertains to timeout increases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants