Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F organization policy #30920

Merged
merged 57 commits into from
May 5, 2023
Merged

Conversation

danielw-aws
Copy link
Contributor

Description

Added a data source, docs, and tests for a wrapper for the DescribePolicy API

Relations

Closes #15398

References

DescribePolicy API

Output from Acceptance Testing

TBC

 make testacc TESTS=TestAccOrganizationPolicyDataSource_ PKG=organizations
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/organizations/... -v -count 1 -parallel 20 -run='TestAccOrganizationPolicyDataSource_'  -timeout 180m
=== RUN   TestAccOrganizationPolicyDataSource_UnattachedPolicy
    acctest.go:883: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccOrganizationPolicyDataSource_UnattachedPolicy (1.19s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/organizations      4.189s

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 24, 2023
@ewbankkit ewbankkit added new-data-source Introduces a new data source. service/organizations Issues and PRs that pertain to the organizations service. partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 24, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 25, 2023
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 26, 2023
@ewbankkit ewbankkit self-assigned this May 5, 2023
@github-actions github-actions bot added the generators Relates to code generators. label May 5, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOrganizationsPolicyDataSource_' PKG=organizations
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/organizations/... -v -count 1 -parallel 20  -run=TestAccOrganizationsPolicyDataSource_ -timeout 180m
=== RUN   TestAccOrganizationsPolicyDataSource_UnattachedPolicy
    acctest.go:895: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccOrganizationsPolicyDataSource_UnattachedPolicy (0.84s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/organizations	5.990s

@ewbankkit
Copy link
Contributor

@danielw-aws Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 60ee273 into hashicorp:main May 5, 2023
@github-actions github-actions bot added this to the v4.67.0 milestone May 5, 2023
This was referenced May 8, 2023
@github-actions
Copy link

This functionality has been released in v4.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. partner Contribution from a partner. service/organizations Issues and PRs that pertain to the organizations service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Organizations policy data source
2 participants