Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated catalog and schema reference for quicksight data set #30704

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

morganchorlton3
Copy link
Contributor

@morganchorlton3 morganchorlton3 commented Apr 13, 2023

Added a fix for create data set
Reference to catalog and schema were incorrect

Closes #30702

References

Output from Acceptance Testing


...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/quicksight Issues and PRs that pertain to the quicksight service. needs-triage Waiting for first response or review from a maintainer. labels Apr 13, 2023
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Apr 13, 2023
@jar-b jar-b self-assigned this Apr 13, 2023
@jar-b jar-b marked this pull request as ready for review April 13, 2023 19:52
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=quicksight TESTS=TestAccQuickSightDataSet_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/quicksight/... -v -count 1 -parallel 20 -run='TestAccQuickSightDataSet_'  -timeout 180m

--- PASS: TestAccQuickSightDataSet_disappears (30.51s)
--- PASS: TestAccQuickSightDataSet_columnGroups (35.54s)
--- PASS: TestAccQuickSightDataSet_dataSetUsageConfiguration (35.55s)
--- PASS: TestAccQuickSightDataSet_basic (35.69s)
--- PASS: TestAccQuickSightDataSet_rowLevelPermissionTagConfiguration (35.73s)
--- PASS: TestAccQuickSightDataSet_fieldFolders (35.76s)
--- PASS: TestAccQuickSightDataSet_columnLevelPermissionRules (35.78s)
--- PASS: TestAccQuickSightDataSet_logicalTableMap (35.84s)
--- PASS: TestAccQuickSightDataSet_tags (68.48s)
--- PASS: TestAccQuickSightDataSet_permissions (74.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/quicksight 77.336s

@jar-b jar-b merged commit affd7cc into hashicorp:main Apr 13, 2023
@jar-b
Copy link
Member

jar-b commented Apr 13, 2023

Thanks for the bug report and fix, @morganchorlton3! 👏

@github-actions github-actions bot added this to the v4.63.0 milestone Apr 13, 2023
@morganchorlton3 morganchorlton3 deleted the b-quicksight-data-set-table-fix branch April 14, 2023 07:16
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

alewando pushed a commit to alewando/terraform-provider-aws that referenced this pull request Apr 14, 2023
…rp#30704)

* updated catalog and schema reference for quicksight data set

* chore: changelog

---------

Co-authored-by: Jared Baker <jared.baker@hashicorp.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/quicksight Issues and PRs that pertain to the quicksight service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Quicksight Dataset Not Using relational_table Fields Correctly
2 participants