Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support startup scripts in MWAA #30549

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

wedge-jarrad
Copy link
Contributor

Description

Add startup_script_s3_path and startup_script_s3_object_version attributes.

Update _full acceptance test to use MWAA version 2.4.3 since 1.x does not support some of the newer features, including startup scripts and is scheduled for deprecation https://docs.aws.amazon.com/mwaa/latest/userguide/airflow-versions.html#airflow-versions-deprecation

Relations

Closes #30473

References

https://aws.amazon.com/about-aws/whats-new/2023/04/amazon-mwaa-shell-launch-scripts/
https://docs.aws.amazon.com/mwaa/latest/userguide/using-startup-script.html

Output from Acceptance Testing

$ gmake testacc TESTS=TestAccMWAAEnvironment PKG=mwaa
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/mwaa/... -v -count 1 -parallel 20 -run='TestAccMWAAEnvironment'  -timeout 180m
=== RUN   TestAccMWAAEnvironment_basic
=== PAUSE TestAccMWAAEnvironment_basic
=== RUN   TestAccMWAAEnvironment_disappears
=== PAUSE TestAccMWAAEnvironment_disappears
=== RUN   TestAccMWAAEnvironment_airflowOptions
=== PAUSE TestAccMWAAEnvironment_airflowOptions
=== RUN   TestAccMWAAEnvironment_log
=== PAUSE TestAccMWAAEnvironment_log
=== RUN   TestAccMWAAEnvironment_full
=== PAUSE TestAccMWAAEnvironment_full
=== RUN   TestAccMWAAEnvironment_pluginsS3ObjectVersion
=== PAUSE TestAccMWAAEnvironment_pluginsS3ObjectVersion
=== CONT  TestAccMWAAEnvironment_basic
=== CONT  TestAccMWAAEnvironment_log
=== CONT  TestAccMWAAEnvironment_full
=== CONT  TestAccMWAAEnvironment_pluginsS3ObjectVersion
=== CONT  TestAccMWAAEnvironment_disappears
=== CONT  TestAccMWAAEnvironment_airflowOptions
--- PASS: TestAccMWAAEnvironment_basic (3443.49s)
--- PASS: TestAccMWAAEnvironment_disappears (3679.55s)
--- PASS: TestAccMWAAEnvironment_full (3705.46s)
--- PASS: TestAccMWAAEnvironment_log (4746.59s)
--- PASS: TestAccMWAAEnvironment_pluginsS3ObjectVersion (4866.58s)
--- PASS: TestAccMWAAEnvironment_airflowOptions (6105.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/mwaa	6105.274s

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/mwaa Issues and PRs that pertain to the mwaa service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Apr 9, 2023
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 10, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

--- PASS: TestAccMWAAEnvironment_basic (3515.30s)
--- PASS: TestAccMWAAEnvironment_pluginsS3ObjectVersion (4908.43s)

@ewbankkit
Copy link
Contributor

@wedge-jarrad Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 90fc912 into hashicorp:main Apr 10, 2023
@github-actions github-actions bot added this to the v4.63.0 milestone Apr 10, 2023
@wedge-jarrad wedge-jarrad deleted the f-mwaa-startup-script branch April 11, 2023 03:29
@github-actions
Copy link

This functionality has been released in v4.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/mwaa Issues and PRs that pertain to the mwaa service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: mwaa resource does not support startup script
2 participants