Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource - aws_oam_link #30125

Merged
merged 10 commits into from
Mar 20, 2023
Merged

Conversation

royrajan13
Copy link

Description

This pull requests add an aws_oam_link resource which provides the ability to create a link to a aws_oam_sink.

Relations

Relates #28158

References

CreateLink API documentation

Output from Acceptance Testing

➜ make testacc PKG=oam
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/oam/... -v -count 1 -parallel 20   -timeout 180m
=== RUN   TestExpandResourceTypesUnitTest
=== RUN   TestExpandResourceTypesUnitTest/Empty_resource_types
=== RUN   TestExpandResourceTypesUnitTest/Non-empty_resource_types
--- PASS: TestExpandResourceTypesUnitTest (0.00s)
    --- PASS: TestExpandResourceTypesUnitTest/Empty_resource_types (0.00s)
    --- PASS: TestExpandResourceTypesUnitTest/Non-empty_resource_types (0.00s)
=== RUN   TestResourceTypeValuesUnitTest
=== RUN   TestResourceTypeValuesUnitTest/Empty_resource_types
=== RUN   TestResourceTypeValuesUnitTest/Non-empty_resource_types
--- PASS: TestResourceTypeValuesUnitTest (0.00s)
    --- PASS: TestResourceTypeValuesUnitTest/Empty_resource_types (0.00s)
    --- PASS: TestResourceTypeValuesUnitTest/Non-empty_resource_types (0.00s)
=== RUN   TestAccObservabilityAccessManagerLink_basic
--- PASS: TestAccObservabilityAccessManagerLink_basic (167.57s)
=== RUN   TestAccObservabilityAccessManagerLink_disappears
--- PASS: TestAccObservabilityAccessManagerLink_disappears (128.20s)
=== RUN   TestAccObservabilityAccessManagerLink_update
--- PASS: TestAccObservabilityAccessManagerLink_update (255.12s)
=== RUN   TestAccObservabilityAccessManagerLink_tags
--- PASS: TestAccObservabilityAccessManagerLink_tags (347.29s)
...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/oam Issues and PRs that pertain to the oam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Mar 19, 2023
@breathingdust breathingdust added partner Contribution from a partner. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 20, 2023
@github-actions github-actions bot added flex Pertains to FLatteners and EXpanders. service/inspector2 Issues and PRs that pertain to the inspector2 service. labels Mar 20, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccObservabilityAccessManagerLink_' PKG=oam ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/oam/... -v -count 1 -parallel 3  -run=TestAccObservabilityAccessManagerLink_ -timeout 180m
=== RUN   TestAccObservabilityAccessManagerLink_basic
--- PASS: TestAccObservabilityAccessManagerLink_basic (34.16s)
=== RUN   TestAccObservabilityAccessManagerLink_disappears
--- PASS: TestAccObservabilityAccessManagerLink_disappears (22.38s)
=== RUN   TestAccObservabilityAccessManagerLink_update
--- PASS: TestAccObservabilityAccessManagerLink_update (55.60s)
=== RUN   TestAccObservabilityAccessManagerLink_tags
--- PASS: TestAccObservabilityAccessManagerLink_tags (74.49s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/oam	188.609s
% make testacc TESTARGS='-run=TestAccInspector2Enabler_serial' PKG=inspector2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/inspector2/... -v -count 1 -parallel 20  -run=TestAccInspector2Enabler_serial -timeout 180m
=== RUN   TestAccInspector2Enabler_serial
=== PAUSE TestAccInspector2Enabler_serial
=== CONT  TestAccInspector2Enabler_serial
=== RUN   TestAccInspector2Enabler_serial/disappears
=== RUN   TestAccInspector2Enabler_serial/basic        
=== RUN   TestAccInspector2Enabler_serial/accountID
--- PASS: TestAccInspector2Enabler_serial (1382.43s)
    --- PASS: TestAccInspector2Enabler_serial/disappears (217.26s)
    --- PASS: TestAccInspector2Enabler_serial/basic (909.05s)
    --- PASS: TestAccInspector2Enabler_serial/accountID (256.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/inspector2	1387.656s

@ewbankkit ewbankkit self-assigned this Mar 20, 2023
@ewbankkit
Copy link
Contributor

@royrajan13 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e8fbc08 into hashicorp:main Mar 20, 2023
@github-actions github-actions bot added this to the v4.60.0 milestone Mar 20, 2023
@github-actions
Copy link

This functionality has been released in v4.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@royrajan13 royrajan13 deleted the f-aws_oam_link branch April 2, 2023 11:26
@github-actions
Copy link

github-actions bot commented May 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. generators Relates to code generators. partner Contribution from a partner. service/inspector2 Issues and PRs that pertain to the inspector2 service. service/oam Issues and PRs that pertain to the oam service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants