Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend timeouts for aws_budget_actions #29976

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Extend timeouts for aws_budget_actions #29976

merged 1 commit into from
Mar 16, 2023

Conversation

nam054
Copy link
Contributor

@nam054 nam054 commented Mar 14, 2023

Description

This PR adds configurable timeouts for the resource's create and delete and extends the default time from 2 mins to 5 mins.

Relations

Closes #21664
Closes #20125

References

Output from Acceptance Testing

> make testacc TESTARGS='-run=TestAccBudgetsBudgetAction_' PKG=budgets
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 20  -run=TestAccBudgetsBudgetAction_ -timeout 180m
=== RUN   TestAccBudgetsBudgetAction_basic
=== PAUSE TestAccBudgetsBudgetAction_basic
=== RUN   TestAccBudgetsBudgetAction_disappears
=== PAUSE TestAccBudgetsBudgetAction_disappears
=== CONT  TestAccBudgetsBudgetAction_basic
=== CONT  TestAccBudgetsBudgetAction_disappears
--- PASS: TestAccBudgetsBudgetAction_disappears (22.81s)
--- PASS: TestAccBudgetsBudgetAction_basic (32.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    35.427s> make testacc TESTARGS='-run=TestAccBudgetsBudgetAction_' PKG=budgets
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 20  -run=TestAccBudgetsBudgetAction_ -timeout 180m
=== RUN   TestAccBudgetsBudgetAction_basic
=== PAUSE TestAccBudgetsBudgetAction_basic
=== RUN   TestAccBudgetsBudgetAction_disappears
=== PAUSE TestAccBudgetsBudgetAction_disappears
=== CONT  TestAccBudgetsBudgetAction_basic
=== CONT  TestAccBudgetsBudgetAction_disappears
--- PASS: TestAccBudgetsBudgetAction_disappears (22.81s)
--- PASS: TestAccBudgetsBudgetAction_basic (32.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    35.427s

...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/budgets Issues and PRs that pertain to the budgets service. size/XS Managed by automation to categorize the size of a PR. labels Mar 14, 2023
@ewbankkit
Copy link
Contributor

ewbankkit commented Mar 14, 2023

Drive-by thought.
Should we make the timeouts configurable via a timeouts block?

@nam054
Copy link
Contributor Author

nam054 commented Mar 14, 2023

Yes I agree! I'll push up the modifications.

@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Mar 15, 2023
@nam054 nam054 marked this pull request as ready for review March 16, 2023 16:33
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸

$ make testacc TESTARGS='-run=TestAccBudgetsBudgetAction_' PKG=budgets
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 20  -run=TestAccBudgetsBudgetAction_ -timeout 180m
=== RUN   TestAccBudgetsBudgetAction_basic
=== PAUSE TestAccBudgetsBudgetAction_basic
=== RUN   TestAccBudgetsBudgetAction_disappears
=== PAUSE TestAccBudgetsBudgetAction_disappears
=== CONT  TestAccBudgetsBudgetAction_basic
=== CONT  TestAccBudgetsBudgetAction_disappears
--- PASS: TestAccBudgetsBudgetAction_disappears (31.09s)
--- PASS: TestAccBudgetsBudgetAction_basic (32.72s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/budgets    35.911s

@nam054 nam054 merged commit 18c6814 into main Mar 16, 2023
@nam054 nam054 deleted the b-configurable-timeouts branch March 16, 2023 19:31
@github-actions github-actions bot added this to the v4.59.0 milestone Mar 16, 2023
github-actions bot pushed a commit that referenced this pull request Mar 16, 2023
@github-actions
Copy link

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/budgets Issues and PRs that pertain to the budgets service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
3 participants