-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend timeouts for aws_budget_actions #29976
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Drive-by thought. |
82a3993
to
67ab3d4
Compare
Yes I agree! I'll push up the modifications. |
67ab3d4
to
c0bee43
Compare
c0bee43
to
be814c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎸
$ make testacc TESTARGS='-run=TestAccBudgetsBudgetAction_' PKG=budgets
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/budgets/... -v -count 1 -parallel 20 -run=TestAccBudgetsBudgetAction_ -timeout 180m
=== RUN TestAccBudgetsBudgetAction_basic
=== PAUSE TestAccBudgetsBudgetAction_basic
=== RUN TestAccBudgetsBudgetAction_disappears
=== PAUSE TestAccBudgetsBudgetAction_disappears
=== CONT TestAccBudgetsBudgetAction_basic
=== CONT TestAccBudgetsBudgetAction_disappears
--- PASS: TestAccBudgetsBudgetAction_disappears (31.09s)
--- PASS: TestAccBudgetsBudgetAction_basic (32.72s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/budgets 35.911s
This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds configurable timeouts for the resource's create and delete and extends the default time from 2 mins to 5 mins.
Relations
Closes #21664
Closes #20125
References
Output from Acceptance Testing