Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: specify "DP" as the input volume type while using aws_fsx_ontap_volume resource #29456

Closed
amit15er opened this issue Feb 16, 2023 · 5 comments · Fixed by #31544
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/fsx Issues and PRs that pertain to the fsx service.
Milestone

Comments

@amit15er
Copy link

Description

AWS launched the ability to create DP volumes natively via Console/API (as well as CFN). Unfortunately terraform provider for AWS do not provide that option yet.

Affected Resource(s) and/or Data Source(s)

aws_fsx_ontap_volume

Potential Terraform Configuration

No response

References

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/fsx_ontap_volume

Would you like to implement a fix?

None

@amit15er amit15er added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Feb 16, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@amit15er
Copy link
Author

Past re:Invent, AWS launched the ability to create DP volumes natively via our Console/API (as well as CFN). Refer :
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-fsx-volume-ontapconfiguration.html#cfn-fsx-volume-ontapconfiguration-ontapvolumetype

The golang resource backend is using the Values() function from the SDK :
https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/fsx/ontap_volume.go#L117

But not sure why https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/fsx_ontap_volume page do not reflect the same?

@amit15er
Copy link
Author

I also tried with latest ver of provider as well as terraform binary version, but no luck :

terraform {
  required_version = "~> 1.3.8"

  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = ">= 4.55"
    }
  }
}

Getting below error :
% terraform validate

│ Error: Value for unconfigurable attribute

│ with module.fsx_ontap_dev_single_az.aws_fsx_ontap_volume.this,
│ on ../main.tf line 44, in resource "aws_fsx_ontap_volume" "this":
│ 44: ontap_volume_type = var.volumes[count.index].ontap_volume_type

│ Can't configure a value for "ontap_volume_type": its value will be decided automatically based on the result of applying
│ this configuration.

resource definition :

resource "aws_fsx_ontap_volume" "this" {
  count = length(var.volumes)

  storage_virtual_machine_id = aws_fsx_ontap_storage_virtual_machine.this.id
  name                       = var.volumes[count.index].name
  junction_path              = var.volumes[count.index].junction_path
  size_in_megabytes          = var.volumes[count.index].size_in_megabytes
  security_style             = var.volumes[count.index].security_style
  storage_efficiency_enabled = var.volumes[count.index].storage_efficiency_enabled
  ontap_volume_type          = var.volumes[count.index].ontap_volume_type 
  tags                       = local.tags
}

variable declaration :

variable "volumes" {
  description = "collection of FSx ONTAP Volumnes "
  type = list(object({
    name                       = string
    junction_path              = string
    size_in_megabytes          = number
    storage_efficiency_enabled = string
    security_style             = string
    tiering_policy_name        = string
    tiering_policy_cooling     = string
    ontap_volume_type          = string 
  }))
}

@johnsonaj johnsonaj added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/fsx Issues and PRs that pertain to the fsx service. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 23, 2023
@github-actions github-actions bot added this to the v5.1.0 milestone May 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/fsx Issues and PRs that pertain to the fsx service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants