-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/networkmanager connect peer #29296
r/networkmanager connect peer #29296
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Connect peer supports only 32bit ASN so can use int validation directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccNetworkManagerConnectPeer_' PKG=networkmanager ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkmanager/... -v -count 1 -parallel 3 -run=TestAccNetworkManagerConnectPeer_ -timeout 180m
=== RUN TestAccNetworkManagerConnectPeer_basic
=== PAUSE TestAccNetworkManagerConnectPeer_basic
=== RUN TestAccNetworkManagerConnectPeer_noDependsOn
=== PAUSE TestAccNetworkManagerConnectPeer_noDependsOn
=== RUN TestAccNetworkManagerConnectPeer_tags
=== PAUSE TestAccNetworkManagerConnectPeer_tags
=== CONT TestAccNetworkManagerConnectPeer_basic
=== CONT TestAccNetworkManagerConnectPeer_tags
=== CONT TestAccNetworkManagerConnectPeer_noDependsOn
--- PASS: TestAccNetworkManagerConnectPeer_noDependsOn (1530.08s)
--- PASS: TestAccNetworkManagerConnectPeer_tags (1516.11s)
--- PASS: TestAccNetworkManagerConnectPeer_basic (1540.56s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/networkmanager 1548.176s
@juhala-aws Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add new resource AWS Network Manager Connect Peer
Relations
Closes: #28987
References
Create Connect Peer API action: https://docs.aws.amazon.com/networkmanager/latest/APIReference/API_CreateConnectPeer.html
Create Connect Peer API data type: https://docs.aws.amazon.com/networkmanager/latest/APIReference/API_ConnectPeer.html
Output from Acceptance Testing