Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved RequiredWith from wrong attribute on an appmesh route #29217

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Moved RequiredWith from wrong attribute on an appmesh route #29217

merged 3 commits into from
Feb 10, 2023

Conversation

bjernie
Copy link
Contributor

@bjernie bjernie commented Feb 2, 2023

If you create an aws_appmesh_route and provide a spec.0.grpc_route.0.match.service_name it gives an error that you also need to specify a spec.0.grpc_route.0.match.method_name when it is actually the other way around.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/appmesh Issues and PRs that pertain to the appmesh service. labels Feb 2, 2023
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 2, 2023
@bjernie bjernie changed the title Moved RequiredWith from appmesh route spec.0.grpc_route.0.match.0.service_name to Moved RequiredWith from wrong attribute on an appmesh route Feb 2, 2023
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 2, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

plan now returns the proper error message:

│ Error: Missing required argument
│
│   with aws_appmesh_route.test,
│   on main.tf line 58, in resource "aws_appmesh_route" "test":
│   58:       match {
│
│ "spec.0.grpc_route.0.match.0.method_name": all of `spec.0.grpc_route.0.match.0.method_name,spec.0.grpc_route.0.match.0.service_name` must be specified

GRPC Route Match Docs: https://docs.aws.amazon.com/app-mesh/latest/APIReference/API_GrpcRouteMatch.html

@jar-b jar-b merged commit 5848ccf into hashicorp:main Feb 10, 2023
@github-actions github-actions bot added this to the v4.55.0 milestone Feb 10, 2023
@jar-b
Copy link
Member

jar-b commented Feb 10, 2023

Thanks for your contribution, @bjernie! 👏

@bjernie bjernie deleted the appmesh-route-requirement-fix branch February 10, 2023 20:52
@github-actions
Copy link

This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/appmesh Issues and PRs that pertain to the appmesh service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants