Bugfix: Allow HA configuration of aws_lightsail_database

[brittandeyoung]

Description

The following PR was made to expedite the fixes associated with this original PR: #26488 . The Commits where brought into this PR to give original author credit. This PR makes the availability_zone optional as this field is not allowed when using an HA blueprint. Resource functions where also updated to support context.

Relations

Closes #26488.
Closes #26137.

References

Output from Acceptance Testing

➜ terraform-provider-aws (b-aws_lightsail_database_HA) ✗ make testacc TESTARGS='-run=TestAccLightsailDatabase' PKG=lightsail                        
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDatabase -timeout 180m
=== RUN   TestAccLightsailDatabase_basic
=== PAUSE TestAccLightsailDatabase_basic
=== RUN   TestAccLightsailDatabase_RelationalDatabaseName
=== PAUSE TestAccLightsailDatabase_RelationalDatabaseName
=== RUN   TestAccLightsailDatabase_MasterDatabaseName
=== PAUSE TestAccLightsailDatabase_MasterDatabaseName
=== RUN   TestAccLightsailDatabase_MasterUsername
=== PAUSE TestAccLightsailDatabase_MasterUsername
=== RUN   TestAccLightsailDatabase_MasterPassword
=== PAUSE TestAccLightsailDatabase_MasterPassword
=== RUN   TestAccLightsailDatabase_PreferredBackupWindow
=== PAUSE TestAccLightsailDatabase_PreferredBackupWindow
=== RUN   TestAccLightsailDatabase_PreferredMaintenanceWindow
=== PAUSE TestAccLightsailDatabase_PreferredMaintenanceWindow
=== RUN   TestAccLightsailDatabase_PubliclyAccessible
=== PAUSE TestAccLightsailDatabase_PubliclyAccessible
=== RUN   TestAccLightsailDatabase_BackupRetentionEnabled
=== PAUSE TestAccLightsailDatabase_BackupRetentionEnabled
=== RUN   TestAccLightsailDatabase_FinalSnapshotName
=== PAUSE TestAccLightsailDatabase_FinalSnapshotName
=== RUN   TestAccLightsailDatabase_Tags
=== PAUSE TestAccLightsailDatabase_Tags
=== RUN   TestAccLightsailDatabase_ha
=== PAUSE TestAccLightsailDatabase_ha
=== RUN   TestAccLightsailDatabase_disappears
=== PAUSE TestAccLightsailDatabase_disappears
=== CONT  TestAccLightsailDatabase_basic
=== CONT  TestAccLightsailDatabase_PubliclyAccessible
=== CONT  TestAccLightsailDatabase_MasterUsername
=== CONT  TestAccLightsailDatabase_MasterDatabaseName
=== CONT  TestAccLightsailDatabase_RelationalDatabaseName
=== CONT  TestAccLightsailDatabase_Tags
=== CONT  TestAccLightsailDatabase_disappears
=== CONT  TestAccLightsailDatabase_ha
=== CONT  TestAccLightsailDatabase_FinalSnapshotName
=== CONT  TestAccLightsailDatabase_BackupRetentionEnabled
=== CONT  TestAccLightsailDatabase_MasterPassword
=== CONT  TestAccLightsailDatabase_PreferredMaintenanceWindow
=== CONT  TestAccLightsailDatabase_PreferredBackupWindow
--- PASS: TestAccLightsailDatabase_MasterPassword (8.29s)
--- PASS: TestAccLightsailDatabase_disappears (539.34s)
--- PASS: TestAccLightsailDatabase_PreferredBackupWindow (694.01s)
--- PASS: TestAccLightsailDatabase_RelationalDatabaseName (694.53s)
--- PASS: TestAccLightsailDatabase_PreferredMaintenanceWindow (722.07s)
--- PASS: TestAccLightsailDatabase_Tags (807.02s)
--- PASS: TestAccLightsailDatabase_basic (826.95s)
--- PASS: TestAccLightsailDatabase_PubliclyAccessible (827.48s)
--- PASS: TestAccLightsailDatabase_BackupRetentionEnabled (998.96s)
--- PASS: TestAccLightsailDatabase_FinalSnapshotName (1006.00s)
--- PASS: TestAccLightsailDatabase_ha (1253.48s)
--- PASS: TestAccLightsailDatabase_MasterUsername (1471.81s)
--- PASS: TestAccLightsailDatabase_MasterDatabaseName (1476.56s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  1478.811s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsailDatabase_' PKG=lightsail ACCTEST_PARALLELISM=3 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 3  -run=TestAccLightsailDatabase_ -timeout 180m
=== RUN   TestAccLightsailDatabase_basic
=== PAUSE TestAccLightsailDatabase_basic
=== RUN   TestAccLightsailDatabase_relationalDatabaseName
=== PAUSE TestAccLightsailDatabase_relationalDatabaseName
=== RUN   TestAccLightsailDatabase_masterDatabaseName
=== PAUSE TestAccLightsailDatabase_masterDatabaseName
=== RUN   TestAccLightsailDatabase_masterUsername
=== PAUSE TestAccLightsailDatabase_masterUsername
=== RUN   TestAccLightsailDatabase_masterPassword
=== PAUSE TestAccLightsailDatabase_masterPassword
=== RUN   TestAccLightsailDatabase_preferredBackupWindow
=== PAUSE TestAccLightsailDatabase_preferredBackupWindow
=== RUN   TestAccLightsailDatabase_preferredMaintenanceWindow
=== PAUSE TestAccLightsailDatabase_preferredMaintenanceWindow
=== RUN   TestAccLightsailDatabase_publiclyAccessible
=== PAUSE TestAccLightsailDatabase_publiclyAccessible
=== RUN   TestAccLightsailDatabase_backupRetentionEnabled
=== PAUSE TestAccLightsailDatabase_backupRetentionEnabled
=== RUN   TestAccLightsailDatabase_finalSnapshotName
=== PAUSE TestAccLightsailDatabase_finalSnapshotName
=== RUN   TestAccLightsailDatabase_tags
=== PAUSE TestAccLightsailDatabase_tags
=== RUN   TestAccLightsailDatabase_ha
=== PAUSE TestAccLightsailDatabase_ha
=== RUN   TestAccLightsailDatabase_disappears
=== PAUSE TestAccLightsailDatabase_disappears
=== CONT  TestAccLightsailDatabase_basic
=== CONT  TestAccLightsailDatabase_publiclyAccessible
=== CONT  TestAccLightsailDatabase_masterPassword
--- PASS: TestAccLightsailDatabase_masterPassword (5.78s)
=== CONT  TestAccLightsailDatabase_tags
--- PASS: TestAccLightsailDatabase_tags (825.33s)
=== CONT  TestAccLightsailDatabase_disappears
--- PASS: TestAccLightsailDatabase_publiclyAccessible (846.90s)
=== CONT  TestAccLightsailDatabase_ha
--- PASS: TestAccLightsailDatabase_basic (870.36s)
=== CONT  TestAccLightsailDatabase_preferredMaintenanceWindow
--- PASS: TestAccLightsailDatabase_disappears (535.84s)
=== CONT  TestAccLightsailDatabase_preferredBackupWindow
--- PASS: TestAccLightsailDatabase_preferredMaintenanceWindow (718.51s)
=== CONT  TestAccLightsailDatabase_masterDatabaseName
--- PASS: TestAccLightsailDatabase_preferredBackupWindow (759.19s)
=== CONT  TestAccLightsailDatabase_masterUsername
--- PASS: TestAccLightsailDatabase_ha (1437.29s)
=== CONT  TestAccLightsailDatabase_relationalDatabaseName
--- PASS: TestAccLightsailDatabase_masterDatabaseName (1542.86s)
=== CONT  TestAccLightsailDatabase_finalSnapshotName
--- PASS: TestAccLightsailDatabase_relationalDatabaseName (864.14s)
=== CONT  TestAccLightsailDatabase_backupRetentionEnabled
--- PASS: TestAccLightsailDatabase_masterUsername (1468.91s)
--- PASS: TestAccLightsailDatabase_backupRetentionEnabled (959.55s)
--- PASS: TestAccLightsailDatabase_finalSnapshotName (1038.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	4175.415s

[ewbankkit]

@brittandeyoung Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.