Datasync: Add missing option object_tags to aws_datasync_task

[rickard-von-essen]

Description

This adds the missing option objectTags to DataSync task. See API docs - DataSync Options.

Closes #31301.

Output from Acceptance Testing

make testacc TESTS=TestAccDataSyncTask_DefaultSyncOptions_objectTags PKG=datasync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run='TestAccDataSyncTask_DefaultSyncOptions_objectTags'  -timeout 180m
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_objectTags
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_objectTags
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_objectTags
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_objectTags (246.46s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datasync   246.528s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @rickard-von-essen 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[DrFaust92]

missing changelog but otherwise LGTM

[github-actions]

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

[rickard-von-essen]

Sorry for dropping the ball on this..

Fixed the changelog, rebased, and re-runned the IT's:

$ make testacc TESTS=TestAccDataSyncTask_DefaultSyncOptions_objectTags PKG=datasync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20 -run='TestAccDataSyncTask_DefaultSyncOptions_objectTags'  -timeout 180m
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_objectTags
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_objectTags
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_objectTags
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_objectTags (231.19s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datasync   231.274s
$ date
Thu Apr 13 01:12:24 PM CEST 2023

[rickard-von-essen]

@DrFaust92 can we get this merged 🙏🏻 . I fixed the changelog.

[DrFaust92]

LGTM

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDataSyncTask_DefaultSyncOptions_objectTags\|TestAccDataSyncTask_basic$$' PKG=datasync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 20  -run=TestAccDataSyncTask_DefaultSyncOptions_objectTags\|TestAccDataSyncTask_basic$ -timeout 180m
=== RUN   TestAccDataSyncTask_basic
=== PAUSE TestAccDataSyncTask_basic
=== RUN   TestAccDataSyncTask_DefaultSyncOptions_objectTags
=== PAUSE TestAccDataSyncTask_DefaultSyncOptions_objectTags
=== CONT  TestAccDataSyncTask_basic
=== CONT  TestAccDataSyncTask_DefaultSyncOptions_objectTags
--- PASS: TestAccDataSyncTask_basic (170.13s)
--- PASS: TestAccDataSyncTask_DefaultSyncOptions_objectTags (212.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	219.737s

% make testacc TESTARGS='-run=TestAccDataSyncLocationObjectStorage_' PKG=datasync ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/datasync/... -v -count 1 -parallel 2  -run=TestAccDataSyncLocationObjectStorage_ -timeout 180m
=== RUN   TestAccDataSyncLocationObjectStorage_basic
=== PAUSE TestAccDataSyncLocationObjectStorage_basic
=== RUN   TestAccDataSyncLocationObjectStorage_disappears
=== PAUSE TestAccDataSyncLocationObjectStorage_disappears
=== RUN   TestAccDataSyncLocationObjectStorage_tags
=== PAUSE TestAccDataSyncLocationObjectStorage_tags
=== RUN   TestAccDataSyncLocationObjectStorage_serverCertificate
=== PAUSE TestAccDataSyncLocationObjectStorage_serverCertificate
=== CONT  TestAccDataSyncLocationObjectStorage_basic
=== CONT  TestAccDataSyncLocationObjectStorage_tags
--- PASS: TestAccDataSyncLocationObjectStorage_basic (115.55s)
=== CONT  TestAccDataSyncLocationObjectStorage_disappears
--- PASS: TestAccDataSyncLocationObjectStorage_tags (174.17s)
=== CONT  TestAccDataSyncLocationObjectStorage_serverCertificate
--- PASS: TestAccDataSyncLocationObjectStorage_serverCertificate (104.84s)
--- PASS: TestAccDataSyncLocationObjectStorage_disappears (123.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datasync	896.463s

[ewbankkit]

@rickard-von-essen Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.