Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource: aws_ivs_channel #27726

Merged
merged 3 commits into from
Nov 11, 2022
Merged

Conversation

KevinEady
Copy link
Contributor

Description

Add new resource for AWS IVS Channel: aws_ivs_channel. This PR is the third in a set to support the full AWS IVS entities:

  1. Playback Key Pair
  2. Recording Configuration
  3. Channel
  4. Stream Key

Relations

Relates #17272

Output from Acceptance Testing

$ make testacc TESTS=TestAccIVSChannel_ PKG=ivs      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 /Users/eakevinh/go/bin/go1.18.4 test ./internal/service/ivs/... -v -count 1 -parallel 20 -run='TestAccIVSChannel_'  -timeout 180m
=== RUN   TestAccIVSChannel_basic
=== PAUSE TestAccIVSChannel_basic
=== RUN   TestAccIVSChannel_tags
=== PAUSE TestAccIVSChannel_tags
=== RUN   TestAccIVSChannel_update
=== PAUSE TestAccIVSChannel_update
=== RUN   TestAccIVSChannel_disappears
=== PAUSE TestAccIVSChannel_disappears
=== RUN   TestAccIVSChannel_recordingConfiguration
=== PAUSE TestAccIVSChannel_recordingConfiguration
=== CONT  TestAccIVSChannel_basic
=== CONT  TestAccIVSChannel_disappears
=== CONT  TestAccIVSChannel_update
=== CONT  TestAccIVSChannel_recordingConfiguration
=== CONT  TestAccIVSChannel_tags
--- PASS: TestAccIVSChannel_disappears (24.90s)
--- PASS: TestAccIVSChannel_basic (34.09s)
--- PASS: TestAccIVSChannel_recordingConfiguration (48.65s)
--- PASS: TestAccIVSChannel_update (54.51s)
--- PASS: TestAccIVSChannel_tags (70.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ivs        73.610s

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ivs Issues and PRs that pertain to the ivs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Nov 9, 2022
Kevin Eady added 2 commits November 9, 2022 18:46
- Remove multiple consecutive blank lines
Copy link
Contributor Author

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some implementation questions that I wanted to ask which may require some rework, so I wanted to get this PR tonight to grab some feedback. Please take a look. Thanks!

internal/service/ivs/status.go Show resolved Hide resolved
internal/service/ivs/channel.go Show resolved Hide resolved
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Nov 9, 2022
@KevinEady KevinEady marked this pull request as ready for review November 10, 2022 15:48
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccIVSChannel_' PKG=ivs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ivs/... -v -count 1 -parallel 2  -run=TestAccIVSChannel_ -timeout 180m
=== RUN   TestAccIVSChannel_basic
=== PAUSE TestAccIVSChannel_basic
=== RUN   TestAccIVSChannel_tags
=== PAUSE TestAccIVSChannel_tags
=== RUN   TestAccIVSChannel_update
=== PAUSE TestAccIVSChannel_update
=== RUN   TestAccIVSChannel_disappears
=== PAUSE TestAccIVSChannel_disappears
=== RUN   TestAccIVSChannel_recordingConfiguration
=== PAUSE TestAccIVSChannel_recordingConfiguration
=== CONT  TestAccIVSChannel_basic
=== CONT  TestAccIVSChannel_disappears
--- PASS: TestAccIVSChannel_disappears (18.36s)
=== CONT  TestAccIVSChannel_update
--- PASS: TestAccIVSChannel_basic (23.41s)
=== CONT  TestAccIVSChannel_tags
--- PASS: TestAccIVSChannel_update (34.64s)
=== CONT  TestAccIVSChannel_recordingConfiguration
--- PASS: TestAccIVSChannel_tags (46.56s)
--- PASS: TestAccIVSChannel_recordingConfiguration (29.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ivs	86.816s

@ewbankkit
Copy link
Contributor

@KevinEady Thanks for the contribution 🎉 👏.
If you are happy with the comments I can go ahead and merge this.

@KevinEady
Copy link
Contributor Author

Hi @ewbankkit ,

Thanks for the review! Comments sound good to me, so this can go ahead and be merged.

I'll be pushing the final entity, aws_ivs_stream_key data source, on Monday. Enjoy your weekend!

Thanks, Kevin

@ewbankkit ewbankkit merged commit 1ccdc82 into hashicorp:main Nov 11, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 11, 2022
@KevinEady KevinEady deleted the f-ivs-channel branch November 11, 2022 22:27
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ivs Issues and PRs that pertain to the ivs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants