Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Data Source] data vpc ipam pools #27101

Merged
merged 7 commits into from
Oct 11, 2022

Conversation

drewmullen
Copy link
Collaborator

Description

Relations

Closes #22180

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccIPAMPoolsDataSource_basic PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccIPAMPoolsDataSource_basic'  -timeout 180m
=== RUN   TestAccIPAMPoolsDataSource_basic
=== PAUSE TestAccIPAMPoolsDataSource_basic
=== CONT  TestAccIPAMPoolsDataSource_basic
--- PASS: TestAccIPAMPoolsDataSource_basic (79.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        83.193s

...

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ipam Issues and PRs that pertain to the ipam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. needs-triage Waiting for first response or review from a maintainer. service/ipam Issues and PRs that pertain to the ipam service. labels Oct 5, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ipam Issues and PRs that pertain to the ipam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 5, 2022
@drewmullen

This comment was marked as outdated.

@drewmullen drewmullen requested review from GlennChia and removed request for AdamTylerLynch October 10, 2022 12:22
Copy link
Collaborator

@GlennChia GlennChia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @drewmullen, completed my review and requesting a few changes!

internal/service/ec2/ipam_pools_data_source.go Outdated Show resolved Hide resolved
internal/service/ec2/ipam_pools_data_source.go Outdated Show resolved Hide resolved
website/docs/d/vpc_ipam_pools.html.markdown Outdated Show resolved Hide resolved
website/docs/d/vpc_ipam_pools.html.markdown Outdated Show resolved Hide resolved
website/docs/d/vpc_ipam_pools.html.markdown Outdated Show resolved Hide resolved
website/docs/d/vpc_ipam_pools.html.markdown Outdated Show resolved Hide resolved
website/docs/d/vpc_ipam_pools.html.markdown Outdated Show resolved Hide resolved
website/docs/d/vpc_ipam_pools.html.markdown Outdated Show resolved Hide resolved
@drewmullen
Copy link
Collaborator Author

done - ty for the feedback:

make testacc TESTS=TestAccIPAMPoolsDataSource_ PKG=ec2     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccIPAMPoolsDataSource_'  -timeout 180m
=== RUN   TestAccIPAMPoolsDataSource_basic
=== PAUSE TestAccIPAMPoolsDataSource_basic
=== RUN   TestAccIPAMPoolsDataSource_empty
=== PAUSE TestAccIPAMPoolsDataSource_empty
=== CONT  TestAccIPAMPoolsDataSource_basic
=== CONT  TestAccIPAMPoolsDataSource_empty
--- PASS: TestAccIPAMPoolsDataSource_empty (20.72s)
--- PASS: TestAccIPAMPoolsDataSource_basic (92.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        96.420s

Copy link
Collaborator

@GlennChia GlennChia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTS=TestAccIPAMPoolsDataSource_basic PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccIPAMPoolsDataSource_basic'  -timeout 180m
=== RUN   TestAccIPAMPoolsDataSource_basic
=== PAUSE TestAccIPAMPoolsDataSource_basic
=== CONT  TestAccIPAMPoolsDataSource_basic
--- PASS: TestAccIPAMPoolsDataSource_basic (75.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	79.600s

@ewbankkit
Copy link
Contributor

@drewmullen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2bd8ae2 into hashicorp:main Oct 11, 2022
@github-actions github-actions bot added this to the v4.35.0 milestone Oct 11, 2022
@github-actions
Copy link

This functionality has been released in v4.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/ipam Issues and PRs that pertain to the ipam service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support describe-ipam-pools
4 participants