Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add glue execution class option #26188

Merged
merged 14 commits into from
Aug 10, 2022
Merged

add glue execution class option #26188

merged 14 commits into from
Aug 10, 2022

Conversation

chie8842
Copy link

@chie8842 chie8842 commented Aug 9, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26203.

Information

Glue has execution class option, but Terraform doesn't support it.
This PR is to support Glue Execution Class at glue/job.go

References

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 9, 2022
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @chie8842 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR. size/XS Managed by automation to categorize the size of a PR. labels Aug 10, 2022
@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Aug 10, 2022
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Aug 10, 2022
@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Aug 10, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGlueJob_' PKG=glue ACCTEST_PARALLELISM=2          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/glue/... -v -count 1 -parallel 2  -run=TestAccGlueJob_ -timeout 180m
=== RUN   TestAccGlueJob_basic
=== PAUSE TestAccGlueJob_basic
=== RUN   TestAccGlueJob_disappears
=== PAUSE TestAccGlueJob_disappears
=== RUN   TestAccGlueJob_basicStreaming
=== PAUSE TestAccGlueJob_basicStreaming
=== RUN   TestAccGlueJob_command
=== PAUSE TestAccGlueJob_command
=== RUN   TestAccGlueJob_defaultArguments
=== PAUSE TestAccGlueJob_defaultArguments
=== RUN   TestAccGlueJob_nonOverridableArguments
=== PAUSE TestAccGlueJob_nonOverridableArguments
=== RUN   TestAccGlueJob_description
=== PAUSE TestAccGlueJob_description
=== RUN   TestAccGlueJob_glueVersion
=== PAUSE TestAccGlueJob_glueVersion
=== RUN   TestAccGlueJob_executionClass
=== PAUSE TestAccGlueJob_executionClass
=== RUN   TestAccGlueJob_executionProperty
=== PAUSE TestAccGlueJob_executionProperty
=== RUN   TestAccGlueJob_maxRetries
=== PAUSE TestAccGlueJob_maxRetries
=== RUN   TestAccGlueJob_notificationProperty
=== PAUSE TestAccGlueJob_notificationProperty
=== RUN   TestAccGlueJob_tags
=== PAUSE TestAccGlueJob_tags
=== RUN   TestAccGlueJob_streamingTimeout
=== PAUSE TestAccGlueJob_streamingTimeout
=== RUN   TestAccGlueJob_timeout
=== PAUSE TestAccGlueJob_timeout
=== RUN   TestAccGlueJob_security
=== PAUSE TestAccGlueJob_security
=== RUN   TestAccGlueJob_workerType
=== PAUSE TestAccGlueJob_workerType
=== RUN   TestAccGlueJob_pythonShell
=== PAUSE TestAccGlueJob_pythonShell
=== RUN   TestAccGlueJob_maxCapacity
=== PAUSE TestAccGlueJob_maxCapacity
=== CONT  TestAccGlueJob_basic
=== CONT  TestAccGlueJob_maxRetries
--- PASS: TestAccGlueJob_basic (25.62s)
=== CONT  TestAccGlueJob_security
--- PASS: TestAccGlueJob_maxRetries (40.97s)
=== CONT  TestAccGlueJob_maxCapacity
--- PASS: TestAccGlueJob_security (38.52s)
=== CONT  TestAccGlueJob_pythonShell
--- PASS: TestAccGlueJob_maxCapacity (39.82s)
=== CONT  TestAccGlueJob_workerType
--- PASS: TestAccGlueJob_pythonShell (55.28s)
=== CONT  TestAccGlueJob_nonOverridableArguments
--- PASS: TestAccGlueJob_workerType (54.13s)
=== CONT  TestAccGlueJob_executionProperty
--- PASS: TestAccGlueJob_nonOverridableArguments (37.92s)
=== CONT  TestAccGlueJob_executionClass
--- PASS: TestAccGlueJob_executionClass (37.08s)
=== CONT  TestAccGlueJob_glueVersion
--- PASS: TestAccGlueJob_executionProperty (38.94s)
=== CONT  TestAccGlueJob_description
--- PASS: TestAccGlueJob_description (36.75s)
=== CONT  TestAccGlueJob_command
--- PASS: TestAccGlueJob_glueVersion (51.60s)
=== CONT  TestAccGlueJob_defaultArguments
--- PASS: TestAccGlueJob_command (36.90s)
=== CONT  TestAccGlueJob_disappears
--- PASS: TestAccGlueJob_defaultArguments (36.32s)
=== CONT  TestAccGlueJob_streamingTimeout
--- PASS: TestAccGlueJob_disappears (17.64s)
=== CONT  TestAccGlueJob_timeout
--- PASS: TestAccGlueJob_streamingTimeout (37.75s)
=== CONT  TestAccGlueJob_tags
--- PASS: TestAccGlueJob_timeout (39.20s)
=== CONT  TestAccGlueJob_notificationProperty
--- PASS: TestAccGlueJob_notificationProperty (35.73s)
=== CONT  TestAccGlueJob_basicStreaming
--- PASS: TestAccGlueJob_tags (50.81s)
--- PASS: TestAccGlueJob_basicStreaming (20.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	365.760s

@ewbankkit
Copy link
Contributor

@chie8842 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4528d18 into hashicorp:main Aug 10, 2022
@github-actions github-actions bot added this to the v4.26.0 milestone Aug 10, 2022
@github-actions
Copy link

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_glue_job provide execution class flex
2 participants