Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AWS Transfer Service AS2 Protocol #26007

Closed
jay4e opened this issue Jul 27, 2022 · 3 comments · Fixed by #26008
Closed

Support for AWS Transfer Service AS2 Protocol #26007

jay4e opened this issue Jul 27, 2022 · 3 comments · Fixed by #26008
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service.
Milestone

Comments

@jay4e
Copy link

jay4e commented Jul 27, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS Transfer Family released support for the AS2 protocol. https://aws.amazon.com/about-aws/whats-new/2022/07/aws-transfer-family-support-applicability-statement-2-as2/

This should be added to the aws_transfer_family/aws_transfer_server options.

New or Affected Resource(s)

  • aws_transfer_server
  • aws_transfer_user
  • aws_transfer_mailbox (AS2 mailbox if not part of user?)

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

  • #0000
@jay4e jay4e added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 27, 2022
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 27, 2022
@justinretzolk
Copy link
Member

Hey @jay4e 👋 Thank you for taking the time to raise this! The aws_transfer_server resource uses transfer.Protocol_Values() from the AWS Go SDK to validate the value supplied to the protocol argument. This enum was updated in AWS Go SDK v1.44.63 to include AS2, and the provider has already been bumped to use this version in the next release, so this should automatically work when AWS Provider version 4.24.0 is released 🎉.

I've opened a PR to update the documentation as well, so that the docs will reflect properly when the next release happens.

@justinretzolk justinretzolk added this to the v4.24.0 milestone Jul 27, 2022
@justinretzolk justinretzolk added service/transfer Issues and PRs that pertain to the transfer service. documentation Introduces or discusses updates to documentation. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 27, 2022
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

This functionality has been released in v4.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 3, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/transfer Issues and PRs that pertain to the transfer service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants