Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_transcribe_vocabulary #25863

Merged
merged 17 commits into from
Jul 19, 2022
Merged

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Jul 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates to #18865

Output from acceptance testing:

Commercial

$ make testacc TESTS=TestAccTranscribeVocabulary_ PKG=transcribe

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transcribe/... -v -count 1 -parallel 20 -run='TestAccTranscribeVocabulary_'  -timeout 180m
=== RUN   TestAccTranscribeVocabulary_basic
=== PAUSE TestAccTranscribeVocabulary_basic
=== RUN   TestAccTranscribeVocabulary_basicPhrases
=== PAUSE TestAccTranscribeVocabulary_basicPhrases
=== RUN   TestAccTranscribeVocabulary_updateS3URI
=== PAUSE TestAccTranscribeVocabulary_updateS3URI
=== RUN   TestAccTranscribeVocabulary_updateTags
=== PAUSE TestAccTranscribeVocabulary_updateTags
=== RUN   TestAccTranscribeVocabulary_disappears
=== PAUSE TestAccTranscribeVocabulary_disappears
=== CONT  TestAccTranscribeVocabulary_basic
=== CONT  TestAccTranscribeVocabulary_updateTags
=== CONT  TestAccTranscribeVocabulary_disappears
=== CONT  TestAccTranscribeVocabulary_updateS3URI
=== CONT  TestAccTranscribeVocabulary_basicPhrases
--- PASS: TestAccTranscribeVocabulary_disappears (78.01s)
--- PASS: TestAccTranscribeVocabulary_basicPhrases (78.91s)
--- PASS: TestAccTranscribeVocabulary_basic (80.29s)
--- PASS: TestAccTranscribeVocabulary_updateTags (105.34s)
--- PASS: TestAccTranscribeVocabulary_updateS3URI (123.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transcribe	126.019s
...

Government Cloud

$ make testacc TESTS=TestAccTranscribeVocabulary_ PKG=transcribe

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transcribe/... -v -count 1 -parallel 20 -run='TestAccTranscribeVocabulary_'  -timeout 180m
=== RUN   TestAccTranscribeVocabulary_basic
=== PAUSE TestAccTranscribeVocabulary_basic
=== RUN   TestAccTranscribeVocabulary_basicPhrases
=== PAUSE TestAccTranscribeVocabulary_basicPhrases
=== RUN   TestAccTranscribeVocabulary_updateS3URI
=== PAUSE TestAccTranscribeVocabulary_updateS3URI
=== RUN   TestAccTranscribeVocabulary_updateTags
=== PAUSE TestAccTranscribeVocabulary_updateTags
=== RUN   TestAccTranscribeVocabulary_disappears
=== PAUSE TestAccTranscribeVocabulary_disappears
=== CONT  TestAccTranscribeVocabulary_basic
=== CONT  TestAccTranscribeVocabulary_updateTags
=== CONT  TestAccTranscribeVocabulary_updateS3URI
=== CONT  TestAccTranscribeVocabulary_disappears
=== CONT  TestAccTranscribeVocabulary_basicPhrases
--- PASS: TestAccTranscribeVocabulary_disappears (77.82s)
--- PASS: TestAccTranscribeVocabulary_basicPhrases (78.43s)
--- PASS: TestAccTranscribeVocabulary_basic (80.26s)
--- PASS: TestAccTranscribeVocabulary_updateTags (103.49s)
--- PASS: TestAccTranscribeVocabulary_updateS3URI (121.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transcribe	124.189s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/transcribe Issues and PRs that pertain to the transcribe service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jul 18, 2022
johnsonaj added a commit that referenced this pull request Jul 18, 2022
@johnsonaj johnsonaj marked this pull request as ready for review July 18, 2022 20:43
@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Jul 19, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTranscribeVocabulary_' PKG=transcribe ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transcribe/... -v -count 1 -parallel 2  -run=TestAccTranscribeVocabulary_ -timeout 180m
=== RUN   TestAccTranscribeVocabulary_basic
=== PAUSE TestAccTranscribeVocabulary_basic
=== RUN   TestAccTranscribeVocabulary_basicPhrases
=== PAUSE TestAccTranscribeVocabulary_basicPhrases
=== RUN   TestAccTranscribeVocabulary_updateS3URI
=== PAUSE TestAccTranscribeVocabulary_updateS3URI
=== RUN   TestAccTranscribeVocabulary_updateTags
=== PAUSE TestAccTranscribeVocabulary_updateTags
=== RUN   TestAccTranscribeVocabulary_disappears
=== PAUSE TestAccTranscribeVocabulary_disappears
=== CONT  TestAccTranscribeVocabulary_basic
=== CONT  TestAccTranscribeVocabulary_updateTags
--- PASS: TestAccTranscribeVocabulary_basic (91.60s)
=== CONT  TestAccTranscribeVocabulary_disappears
--- PASS: TestAccTranscribeVocabulary_updateTags (128.70s)
=== CONT  TestAccTranscribeVocabulary_updateS3URI
--- PASS: TestAccTranscribeVocabulary_disappears (85.54s)
=== CONT  TestAccTranscribeVocabulary_basicPhrases
--- PASS: TestAccTranscribeVocabulary_basicPhrases (86.85s)
--- PASS: TestAccTranscribeVocabulary_updateS3URI (135.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transcribe	270.535s

johnsonaj and others added 6 commits July 19, 2022 11:25
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@johnsonaj johnsonaj force-pushed the f-aws_transcribe_vocabulary branch from 6d94c94 to 724cf33 Compare July 19, 2022 16:26
@johnsonaj johnsonaj merged commit 853f78c into main Jul 19, 2022
@johnsonaj johnsonaj deleted the f-aws_transcribe_vocabulary branch July 19, 2022 17:06
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 19, 2022
github-actions bot pushed a commit that referenced this pull request Jul 19, 2022
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/transcribe Issues and PRs that pertain to the transcribe service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants