-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add data source for aws_route53_resolver_firewall_domain_list #25509
add data source for aws_route53_resolver_firewall_domain_list #25509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes requested.
I would like to get @ewbankkit's opinion:
The ResourceFirewallDomainList exposes a list of domains, I feel that should be exposed in the following ways in the data source.
- Domains attribute for the selected FirewallDomainList
- Ability to filter FirewallDomainList(s) by associated Domain (www.example.com).
Thoughts?
internal/service/route53resolver/firewall_domain_list_data_source.go
Outdated
Show resolved
Hide resolved
internal/service/route53resolver/firewall_domain_list_data_source.go
Outdated
Show resolved
Hide resolved
internal/service/route53resolver/firewall_domain_list_data_source.go
Outdated
Show resolved
Hide resolved
internal/service/route53resolver/firewall_domain_list_data_source.go
Outdated
Show resolved
Hide resolved
…_list_id'. Acceptance test output: % make testacc TESTARGS='-run=TestAccRoute53ResolverFirewallDomainListDataSource_' PKG=route53resolver ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2 -run=TestAccRoute53ResolverFirewallDomainListDataSource_ -timeout 180m === RUN TestAccRoute53ResolverFirewallDomainListDataSource_basic --- PASS: TestAccRoute53ResolverFirewallDomainListDataSource_basic (100.53s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver 107.003s
…t' CRUD handlers (hashicorp#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccRoute53ResolverFirewallDomainListDataSource_' PKG=route53resolver ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2 -run=TestAccRoute53ResolverFirewallDomainListDataSource_ -timeout 180m === RUN TestAccRoute53ResolverFirewallDomainListDataSource_basic --- PASS: TestAccRoute53ResolverFirewallDomainListDataSource_basic (90.40s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver 96.375s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRoute53ResolverFirewallDomainListDataSource_' PKG=route53resolver ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2 -run=TestAccRoute53ResolverFirewallDomainListDataSource_ -timeout 180m
=== RUN TestAccRoute53ResolverFirewallDomainListDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallDomainListDataSource_basic (90.40s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver 96.375s
@silvaalbert Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #25492
Output from acceptance testing: