r/sagemaker_notebook_instance - add instance_metadata_service_configuration argument

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25215
Closes #25216

Output from acceptance testing:

$ make testacc TESTS=TestAccSageMakerNotebookInstance_ PKG=sagemaker
--- PASS: TestAccSageMakerNotebookInstance_disappears (399.68s)
--- PASS: TestAccSageMakerNotebookInstance_basic (406.79s)
--- PASS: TestAccSageMakerNotebookInstance_kms (442.46s)
--- PASS: TestAccSageMakerNotebookInstance_tags (487.16s)
--- PASS: TestAccSageMakerNotebookInstance_Platform_identifier (704.11s)
--- PASS: TestAccSageMakerNotebookInstance_Root_access (776.08s)
--- PASS: TestAccSageMakerNotebookInstance_imds (850.37s)
--- PASS: TestAccSageMakerNotebookInstance_update (882.79s)
--- PASS: TestAccSageMakerNotebookInstance_DirectInternet_access (885.72s)
--- PASS: TestAccSageMakerNotebookInstance_lifecycleName (1312.71s)
--- PASS: TestAccSageMakerNotebookInstance_volumeSize (1363.74s)
--- PASS: TestAccSageMakerNotebookInstance_DefaultCode_repository (1366.91s)
--- PASS: TestAccSageMakerNotebookInstance_DefaultCodeRepository_sageMakerRepo (1439.57s)
--- PASS: TestAccSageMakerNotebookInstance_AdditionalCode_repositories (1943.71s)

[jornfranke]

Is there any update when this can be provided?

[ewbankkit]

LGTM 🚀.

% ACCTEST_TIMEOUT=360m make testacc TESTARGS='-run=TestAccSageMakerNotebookInstance_' PKG=sagemaker ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 2  -run=TestAccSageMakerNotebookInstance_ -timeout 360m
=== RUN   TestAccSageMakerNotebookInstance_basic
=== PAUSE TestAccSageMakerNotebookInstance_basic
=== RUN   TestAccSageMakerNotebookInstance_imds
=== PAUSE TestAccSageMakerNotebookInstance_imds
=== RUN   TestAccSageMakerNotebookInstance_update
=== PAUSE TestAccSageMakerNotebookInstance_update
=== RUN   TestAccSageMakerNotebookInstance_volumeSize
=== PAUSE TestAccSageMakerNotebookInstance_volumeSize
=== RUN   TestAccSageMakerNotebookInstance_lifecycleName
=== PAUSE TestAccSageMakerNotebookInstance_lifecycleName
=== RUN   TestAccSageMakerNotebookInstance_tags
=== PAUSE TestAccSageMakerNotebookInstance_tags
=== RUN   TestAccSageMakerNotebookInstance_kms
=== PAUSE TestAccSageMakerNotebookInstance_kms
=== RUN   TestAccSageMakerNotebookInstance_disappears
=== PAUSE TestAccSageMakerNotebookInstance_disappears
=== RUN   TestAccSageMakerNotebookInstance_Root_access
=== PAUSE TestAccSageMakerNotebookInstance_Root_access
=== RUN   TestAccSageMakerNotebookInstance_Platform_identifier
=== PAUSE TestAccSageMakerNotebookInstance_Platform_identifier
=== RUN   TestAccSageMakerNotebookInstance_DirectInternet_access
=== PAUSE TestAccSageMakerNotebookInstance_DirectInternet_access
=== RUN   TestAccSageMakerNotebookInstance_DefaultCode_repository
=== PAUSE TestAccSageMakerNotebookInstance_DefaultCode_repository
=== RUN   TestAccSageMakerNotebookInstance_AdditionalCode_repositories
=== PAUSE TestAccSageMakerNotebookInstance_AdditionalCode_repositories
=== RUN   TestAccSageMakerNotebookInstance_DefaultCodeRepository_sageMakerRepo
=== PAUSE TestAccSageMakerNotebookInstance_DefaultCodeRepository_sageMakerRepo
=== CONT  TestAccSageMakerNotebookInstance_basic
=== CONT  TestAccSageMakerNotebookInstance_disappears
--- PASS: TestAccSageMakerNotebookInstance_disappears (356.67s)
=== CONT  TestAccSageMakerNotebookInstance_DefaultCode_repository
--- PASS: TestAccSageMakerNotebookInstance_basic (703.32s)
=== CONT  TestAccSageMakerNotebookInstance_DefaultCodeRepository_sageMakerRepo
--- PASS: TestAccSageMakerNotebookInstance_DefaultCode_repository (1237.41s)
=== CONT  TestAccSageMakerNotebookInstance_AdditionalCode_repositories
--- PASS: TestAccSageMakerNotebookInstance_DefaultCodeRepository_sageMakerRepo (1267.57s)
=== CONT  TestAccSageMakerNotebookInstance_Platform_identifier
--- PASS: TestAccSageMakerNotebookInstance_Platform_identifier (779.91s)
=== CONT  TestAccSageMakerNotebookInstance_DirectInternet_access
--- PASS: TestAccSageMakerNotebookInstance_DirectInternet_access (856.78s)
=== CONT  TestAccSageMakerNotebookInstance_lifecycleName
--- PASS: TestAccSageMakerNotebookInstance_AdditionalCode_repositories (2120.95s)
=== CONT  TestAccSageMakerNotebookInstance_kms
--- PASS: TestAccSageMakerNotebookInstance_kms (553.31s)
=== CONT  TestAccSageMakerNotebookInstance_tags
--- PASS: TestAccSageMakerNotebookInstance_tags (325.11s)
=== CONT  TestAccSageMakerNotebookInstance_update
--- PASS: TestAccSageMakerNotebookInstance_lifecycleName (1118.95s)
=== CONT  TestAccSageMakerNotebookInstance_volumeSize
--- PASS: TestAccSageMakerNotebookInstance_update (832.84s)
=== CONT  TestAccSageMakerNotebookInstance_Root_access
--- PASS: TestAccSageMakerNotebookInstance_Root_access (832.90s)
=== CONT  TestAccSageMakerNotebookInstance_imds
--- PASS: TestAccSageMakerNotebookInstance_volumeSize (2045.00s)
--- PASS: TestAccSageMakerNotebookInstance_imds (1042.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker	7308.831s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[ewbankkit]

% make providerlint
==> Checking source code with providerlint...

[github-actions]

This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.