-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/vpc_endpoint - add dns_options
and ip_address_type
argument
#25190
Conversation
Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpoint_gatewayBasic' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpoint_gatewayBasic -timeout 180m === RUN TestAccVPCEndpoint_gatewayBasic === PAUSE TestAccVPCEndpoint_gatewayBasic === CONT TestAccVPCEndpoint_gatewayBasic --- PASS: TestAccVPCEndpoint_gatewayBasic (30.72s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 34.762s
Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCPrefixListDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCPrefixListDataSource_ -timeout 180m === RUN TestAccVPCPrefixListDataSource_basic === PAUSE TestAccVPCPrefixListDataSource_basic === RUN TestAccVPCPrefixListDataSource_filter === PAUSE TestAccVPCPrefixListDataSource_filter === RUN TestAccVPCPrefixListDataSource_nameDoesNotOverrideFilter === PAUSE TestAccVPCPrefixListDataSource_nameDoesNotOverrideFilter === CONT TestAccVPCPrefixListDataSource_basic === CONT TestAccVPCPrefixListDataSource_nameDoesNotOverrideFilter === CONT TestAccVPCPrefixListDataSource_filter --- PASS: TestAccVPCPrefixListDataSource_nameDoesNotOverrideFilter (4.49s) --- PASS: TestAccVPCPrefixListDataSource_basic (18.75s) --- PASS: TestAccVPCPrefixListDataSource_filter (17.17s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 29.464s
Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpoint_gatewayBasic\|TestAccVPCEndpoint_interfaceBasic\|TestAccVPCEndpoint_disappears' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpoint_gatewayBasic\|TestAccVPCEndpoint_interfaceBasic\|TestAccVPCEndpoint_disappears -timeout 180m === RUN TestAccVPCEndpoint_gatewayBasic === PAUSE TestAccVPCEndpoint_gatewayBasic === RUN TestAccVPCEndpoint_interfaceBasic === PAUSE TestAccVPCEndpoint_interfaceBasic === RUN TestAccVPCEndpoint_disappears === PAUSE TestAccVPCEndpoint_disappears === CONT TestAccVPCEndpoint_gatewayBasic === CONT TestAccVPCEndpoint_disappears --- PASS: TestAccVPCEndpoint_disappears (34.96s) === CONT TestAccVPCEndpoint_interfaceBasic --- PASS: TestAccVPCEndpoint_gatewayBasic (39.17s) --- PASS: TestAccVPCEndpoint_interfaceBasic (70.19s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 115.148s
Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpoint_ipAddressType' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpoint_ipAddressType -timeout 180m === RUN TestAccVPCEndpoint_ipAddressType === PAUSE TestAccVPCEndpoint_ipAddressType === CONT TestAccVPCEndpoint_ipAddressType --- PASS: TestAccVPCEndpoint_ipAddressType (330.17s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 334.085s
Acceptance test output: % make testacc TESTARGS='-run=TestAccVPCEndpointDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpointDataSource_ -timeout 180m === RUN TestAccVPCEndpointDataSource_gatewayBasic === PAUSE TestAccVPCEndpointDataSource_gatewayBasic === RUN TestAccVPCEndpointDataSource_byID === PAUSE TestAccVPCEndpointDataSource_byID === RUN TestAccVPCEndpointDataSource_byFilter === PAUSE TestAccVPCEndpointDataSource_byFilter === RUN TestAccVPCEndpointDataSource_byTags === PAUSE TestAccVPCEndpointDataSource_byTags === RUN TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags === PAUSE TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags === RUN TestAccVPCEndpointDataSource_interface === PAUSE TestAccVPCEndpointDataSource_interface === CONT TestAccVPCEndpointDataSource_gatewayBasic === CONT TestAccVPCEndpointDataSource_byTags --- PASS: TestAccVPCEndpointDataSource_byTags (31.39s) === CONT TestAccVPCEndpointDataSource_interface --- PASS: TestAccVPCEndpointDataSource_gatewayBasic (31.66s) === CONT TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags --- PASS: TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags (31.21s) === CONT TestAccVPCEndpointDataSource_byFilter --- PASS: TestAccVPCEndpointDataSource_byFilter (29.74s) === CONT TestAccVPCEndpointDataSource_byID --- PASS: TestAccVPCEndpointDataSource_byID (67.13s) --- PASS: TestAccVPCEndpointDataSource_interface (137.23s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 172.994s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccVPCEndpoint_\|TestAccVPCEndpointService_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpoint_\|TestAccVPCEndpointService_ -timeout 180m
=== RUN TestAccVPCEndpointService_basic
=== PAUSE TestAccVPCEndpointService_basic
=== RUN TestAccVPCEndpointService_disappears
=== PAUSE TestAccVPCEndpointService_disappears
=== RUN TestAccVPCEndpointService_tags
=== PAUSE TestAccVPCEndpointService_tags
=== RUN TestAccVPCEndpointService_networkLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_networkLoadBalancerARNs
=== RUN TestAccVPCEndpointService_supportedIPAddressTypes
=== PAUSE TestAccVPCEndpointService_supportedIPAddressTypes
=== RUN TestAccVPCEndpointService_allowedPrincipals
=== PAUSE TestAccVPCEndpointService_allowedPrincipals
=== RUN TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== RUN TestAccVPCEndpointService_privateDNSName
=== PAUSE TestAccVPCEndpointService_privateDNSName
=== RUN TestAccVPCEndpoint_gatewayBasic
=== PAUSE TestAccVPCEndpoint_gatewayBasic
=== RUN TestAccVPCEndpoint_interfaceBasic
=== PAUSE TestAccVPCEndpoint_interfaceBasic
=== RUN TestAccVPCEndpoint_disappears
=== PAUSE TestAccVPCEndpoint_disappears
=== RUN TestAccVPCEndpoint_tags
=== PAUSE TestAccVPCEndpoint_tags
=== RUN TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== PAUSE TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy
=== RUN TestAccVPCEndpoint_gatewayPolicy
=== PAUSE TestAccVPCEndpoint_gatewayPolicy
=== RUN TestAccVPCEndpoint_ignoreEquivalent
=== PAUSE TestAccVPCEndpoint_ignoreEquivalent
=== RUN TestAccVPCEndpoint_ipAddressType
=== PAUSE TestAccVPCEndpoint_ipAddressType
=== RUN TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== PAUSE TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
=== RUN TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
=== RUN TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== PAUSE TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
=== RUN TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== PAUSE TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer
=== CONT TestAccVPCEndpointService_basic
=== CONT TestAccVPCEndpoint_disappears
--- PASS: TestAccVPCEndpoint_disappears (27.48s)
=== CONT TestAccVPCEndpoint_ipAddressType
--- PASS: TestAccVPCEndpointService_basic (218.63s)
--- PASS: TestAccVPCEndpoint_VPCEndpointType_gatewayLoadBalancer (330.12s)
=== CONT TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate
--- PASS: TestAccVPCEndpoint_ipAddressType (470.19s)
=== CONT TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnUpdate (290.28s)
=== CONT TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup
--- PASS: TestAccVPCEndpoint_interfaceNonAWSServiceAcceptOnCreate (260.93s)
=== CONT TestAccVPCEndpointService_allowedPrincipals
--- PASS: TestAccVPCEndpoint_interfaceWithSubnetAndSecurityGroup (365.90s)
=== CONT TestAccVPCEndpoint_interfaceBasic
--- PASS: TestAccVPCEndpoint_interfaceBasic (82.47s)
=== CONT TestAccVPCEndpoint_gatewayBasic
--- PASS: TestAccVPCEndpoint_gatewayBasic (29.15s)
=== CONT TestAccVPCEndpointService_privateDNSName
--- PASS: TestAccVPCEndpointService_allowedPrincipals (281.93s)
=== CONT TestAccVPCEndpointService_gatewayLoadBalancerARNs
--- PASS: TestAccVPCEndpointService_privateDNSName (257.65s)
=== CONT TestAccVPCEndpoint_gatewayPolicy
--- PASS: TestAccVPCEndpoint_gatewayPolicy (52.03s)
=== CONT TestAccVPCEndpoint_ignoreEquivalent
--- PASS: TestAccVPCEndpointService_gatewayLoadBalancerARNs (188.00s)
=== CONT TestAccVPCEndpointService_networkLoadBalancerARNs
--- PASS: TestAccVPCEndpoint_ignoreEquivalent (41.31s)
=== CONT TestAccVPCEndpointService_supportedIPAddressTypes
--- PASS: TestAccVPCEndpointService_supportedIPAddressTypes (257.50s)
=== CONT TestAccVPCEndpointService_tags
--- PASS: TestAccVPCEndpointService_networkLoadBalancerARNs (408.42s)
=== CONT TestAccVPCEndpointService_disappears
--- PASS: TestAccVPCEndpointService_tags (258.14s)
--- PASS: TestAccVPCEndpoint_gatewayWithRouteTableAndPolicy (51.81s)
=== CONT TestAccVPCEndpoint_tags
--- PASS: TestAccVPCEndpoint_tags (57.28s)
--- PASS: TestAccVPCEndpointService_disappears (232.01s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 1856.484s
% make testacc TESTARGS='-run=TestAccVPCEndpointDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVPCEndpointDataSource_ -timeout 180m
=== RUN TestAccVPCEndpointDataSource_gatewayBasic
=== PAUSE TestAccVPCEndpointDataSource_gatewayBasic
=== RUN TestAccVPCEndpointDataSource_byID
=== PAUSE TestAccVPCEndpointDataSource_byID
=== RUN TestAccVPCEndpointDataSource_byFilter
=== PAUSE TestAccVPCEndpointDataSource_byFilter
=== RUN TestAccVPCEndpointDataSource_byTags
=== PAUSE TestAccVPCEndpointDataSource_byTags
=== RUN TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags
=== PAUSE TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags
=== RUN TestAccVPCEndpointDataSource_interface
=== PAUSE TestAccVPCEndpointDataSource_interface
=== CONT TestAccVPCEndpointDataSource_gatewayBasic
=== CONT TestAccVPCEndpointDataSource_byTags
--- PASS: TestAccVPCEndpointDataSource_byTags (31.39s)
=== CONT TestAccVPCEndpointDataSource_interface
--- PASS: TestAccVPCEndpointDataSource_gatewayBasic (31.66s)
=== CONT TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags
--- PASS: TestAccVPCEndpointDataSource_gatewayWithRouteTableAndTags (31.21s)
=== CONT TestAccVPCEndpointDataSource_byFilter
--- PASS: TestAccVPCEndpointDataSource_byFilter (29.74s)
=== CONT TestAccVPCEndpointDataSource_byID
--- PASS: TestAccVPCEndpointDataSource_byID (67.13s)
--- PASS: TestAccVPCEndpointDataSource_interface (137.23s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 172.994s
% make providerlint golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint... |
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.20.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #24784.
Output from acceptance testing: