Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_appintegrations_data_integration #24941

Merged

Conversation

GlennChia
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24939

Pre-reqs for testing

  1. Create a Salesforce developer account: https://developer.salesforce.com/signup
  2. Create an AppFlow ConnectorProfile and then reference the name of that profile in the DataIntegration source_uri like: Salesforce://AppFlow/<NameOfSalesforceConnectorProfile>. This is set in an environment variable called DATA_INTEGRATION_SOURCE_URI

Output from acceptance testing (if env variables are set):

$ make testacc TESTARGS='-run=TestAccDataIntegration' PKG=appintegrations
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appintegrations/... -v -count 1 -parallel 20  -run=TestAccDataIntegration -timeout 180m
=== RUN   TestAccDataIntegration_basic
=== PAUSE TestAccDataIntegration_basic
=== RUN   TestAccDataIntegration_updateDescription
=== PAUSE TestAccDataIntegration_updateDescription
=== RUN   TestAccDataIntegration_updateName
=== PAUSE TestAccDataIntegration_updateName
=== RUN   TestAccDataIntegration_updateTags
=== PAUSE TestAccDataIntegration_updateTags
=== CONT  TestAccDataIntegration_basic
=== CONT  TestAccDataIntegration_updateName
=== CONT  TestAccDataIntegration_updateDescription
=== CONT  TestAccDataIntegration_updateTags
--- PASS: TestAccDataIntegration_basic (31.68s)
--- PASS: TestAccDataIntegration_updateDescription (48.53s)
--- PASS: TestAccDataIntegration_updateName (51.27s)
--- PASS: TestAccDataIntegration_updateTags (64.74s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appintegrations    64.795s

...

@GlennChia GlennChia marked this pull request as ready for review May 23, 2022 17:40
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appintegrations Issues and PRs that pertain to the appintegrations service. needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 23, 2022
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 23, 2022
@breathingdust breathingdust added the partner Contribution from a partner. label Mar 15, 2023
@ewbankkit ewbankkit self-assigned this May 4, 2023
# Conflicts:
#	internal/provider/provider.go
@github-actions github-actions bot added generators Relates to code generators. and removed provider Pertains to the provider itself, rather than any interaction with AWS. labels May 4, 2023
@github-actions github-actions bot added the provider Pertains to the provider itself, rather than any interaction with AWS. label May 4, 2023
@github-actions github-actions bot removed the provider Pertains to the provider itself, rather than any interaction with AWS. label May 4, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppIntegrationsDataIntegration_' PKG=appintegrations ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appintegrations/... -v -count 1 -parallel 2  -run=TestAccAppIntegrationsDataIntegration_ -timeout 180m
=== RUN   TestAccAppIntegrationsDataIntegration_basic
    data_integration_test.go:31: Environment variable DATA_INTEGRATION_SOURCE_URI is not set
--- SKIP: TestAccAppIntegrationsDataIntegration_basic (0.00s)
=== RUN   TestAccAppIntegrationsDataIntegration_updateDescription
    data_integration_test.go:82: Environment variable DATA_INTEGRATION_SOURCE_URI is not set
--- SKIP: TestAccAppIntegrationsDataIntegration_updateDescription (0.00s)
=== RUN   TestAccAppIntegrationsDataIntegration_updateName
    data_integration_test.go:130: Environment variable DATA_INTEGRATION_SOURCE_URI is not set
--- SKIP: TestAccAppIntegrationsDataIntegration_updateName (0.00s)
=== RUN   TestAccAppIntegrationsDataIntegration_updateTags
    data_integration_test.go:177: Environment variable DATA_INTEGRATION_SOURCE_URI is not set
--- SKIP: TestAccAppIntegrationsDataIntegration_updateTags (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appintegrations	5.885s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e19a84a into hashicorp:main May 4, 2023
@github-actions github-actions bot added this to the v4.66.0 milestone May 4, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/appintegrations Issues and PRs that pertain to the appintegrations service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new resource for aws_appintegrations_data_integration
4 participants