Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_dms_endpoint: Secrets manager secret for aws_dms_endpoint with engine_name = 'aurora', 'mariadb', or 'mysql' #24845

Closed
bmcleodeq opened this issue May 18, 2022 · 2 comments · Fixed by #24846
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dms Issues and PRs that pertain to the dms service.
Milestone

Comments

@bmcleodeq
Copy link
Contributor

bmcleodeq commented May 18, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Use of secret manager secrets for aws_dms_endpoint configuration is better practice than entering credentials into tf. Currently there is only support for oracle and postgres endpoints. I would like to add support for mysql, mariadb and aurora

New or Affected Resource(s)

  • aws_dms_endpoint with engine_name = 'aurora', 'mariadb', or 'mysql'

Potential Terraform Configuration

resource "aws_dms_endpoint" "aurora-with-secrets" {
  endpoint_id                     = "some-id"
  endpoint_type                   = "source"
  engine_name                     = "aurora"
  secrets_manager_access_role_arn = aws_iam_role.test.arn
  secrets_manager_arn             = aws_secretsmanager_secret.test.id
}
resource "aws_dms_endpoint" "mysql-with-secrets" {
  endpoint_id                     = "some-id"
  endpoint_type                   = "source"
  engine_name                     = "mysql"
  secrets_manager_access_role_arn = aws_iam_role.test.arn
  secrets_manager_arn             = aws_secretsmanager_secret.test.id
}
resource "aws_dms_endpoint" "mariadb-with-secrets" {
  endpoint_id                     = "some-id"
  endpoint_type                   = "source"
  engine_name                     = "mariadb"
  secrets_manager_access_role_arn = aws_iam_role.test.arn
  secrets_manager_arn             = aws_secretsmanager_secret.test.id
}

References

@bmcleodeq bmcleodeq added the enhancement Requests to existing resources that expand the functionality or scope. label May 18, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/dms Issues and PRs that pertain to the dms service. labels May 18, 2022
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 18, 2022
@bmcleodeq bmcleodeq changed the title r/aws_dms_endpoint: Secrets manager secret for aws_dms_endpoint with engine_name = 'aurora' or 'mysql' r/aws_dms_endpoint: Secrets manager secret for aws_dms_endpoint with engine_name = 'aurora', 'mariadb', or 'mysql' May 20, 2022
@github-actions github-actions bot added this to the v4.17.0 milestone Jun 1, 2022
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This functionality has been released in v4.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/dms Issues and PRs that pertain to the dms service.
Projects
None yet
2 participants