f-data-networkfirewall_firewall_policy #24748

ddericco · 2022-05-11T22:43:31Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

TODO:

Add support for using name, or both name and ARN (currently only accepts ARN), see https://docs.aws.amazon.com/sdk-for-go/api/service/networkfirewall/#DescribeFirewallPolicyInput
Clean up extraneous comments

Output from acceptance testing:

make testacc TESTS=TestAccFirewallPolicy_arn PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccFirewallPolicy_arn'  -timeout 180m
=== RUN   TestAccFirewallPolicy_arn
=== PAUSE TestAccFirewallPolicy_arn
=== CONT  TestAccFirewallPolicy_arn
--- PASS: TestAccFirewallPolicy_arn (140.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall    143.258s

...

ddericco · 2022-05-12T00:57:43Z

Output from all acceptance tests:

$ make testacc TESTS=TestAccFirewallPolicy_ PKG=networkfirewall 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccFirewallPolicy_'  -timeout 180m
=== RUN   TestAccFirewallPolicy_arn
=== PAUSE TestAccFirewallPolicy_arn
=== RUN   TestAccFirewallPolicy_name
=== PAUSE TestAccFirewallPolicy_name
=== RUN   TestAccFirewallPolicy_nameAndArn
=== PAUSE TestAccFirewallPolicy_nameAndArn
=== CONT  TestAccFirewallPolicy_arn
=== CONT  TestAccFirewallPolicy_nameAndArn
=== CONT  TestAccFirewallPolicy_name
--- PASS: TestAccFirewallPolicy_nameAndArn (133.27s)
--- PASS: TestAccFirewallPolicy_name (133.37s)
--- PASS: TestAccFirewallPolicy_arn (134.55s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall    136.848s

github-actions · 2022-06-20T12:44:53Z

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

github-actions · 2022-06-20T12:44:55Z

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

Check open pull requests with the dependencies label to view other dependency updates.
If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
If this pull request is for supporting a new AWS service:
- Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
- If this pull request is already a separate pull request from the above item, you can ignore this message.

- Fix misc. formatting issues and clean up unneeded comments - Update acceptance tests to compare ARN from datasource and resource - Simplify debugging statements with `diag.Errorf()`

GlennChia

Good first PR @ddericco. Requesting small changes.

internal/service/networkfirewall/firewall_policy_data_source.go

internal/service/networkfirewall/firewall_policy_data_source_test.go

website/docs/d/networkfirewall_firewall_policy.html.markdown

Co-authored-by: Glenn <31919569+GlennChia@users.noreply.github.com>

GlennChia

Second round of reviews

internal/service/networkfirewall/firewall_policy_data_source.go

internal/service/networkfirewall/firewall_policy_data_source_test.go

website/docs/d/networkfirewall_firewall_policy.html.markdown

GlennChia

Changes LGTM. Will need the output of the acceptance tests again since there were a number of changes @ddericco

ddericco · 2022-07-06T14:31:13Z

@GlennChia Output from acceptance test after all changes:

$ make testacc TESTS=TestAccFirewallPolicy_ PKG=networkfirewall
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 20 -run='TestAccFirewallPolicy_'  -timeout 180m
=== RUN   TestAccFirewallPolicy_arn
=== PAUSE TestAccFirewallPolicy_arn
=== RUN   TestAccFirewallPolicy_name
=== PAUSE TestAccFirewallPolicy_name
=== RUN   TestAccFirewallPolicy_nameAndArn
=== PAUSE TestAccFirewallPolicy_nameAndArn
=== CONT  TestAccFirewallPolicy_arn
=== CONT  TestAccFirewallPolicy_name
=== CONT  TestAccFirewallPolicy_nameAndArn
--- PASS: TestAccFirewallPolicy_arn (134.36s)
--- PASS: TestAccFirewallPolicy_name (135.50s)
--- PASS: TestAccFirewallPolicy_nameAndArn (147.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall    151.284s

… test function names.

…ed by blank lines' and 'MD047/single-trailing-newline Files should end with a single newline character'.

ewbankkit

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccNetworkFirewallFirewallPolicyDataSource_' PKG=networkfirewall ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/networkfirewall/... -v -count 1 -parallel 2  -run=TestAccNetworkFirewallFirewallPolicyDataSource_ -timeout 180m
=== RUN   TestAccNetworkFirewallFirewallPolicyDataSource_arn
=== PAUSE TestAccNetworkFirewallFirewallPolicyDataSource_arn
=== RUN   TestAccNetworkFirewallFirewallPolicyDataSource_name
=== PAUSE TestAccNetworkFirewallFirewallPolicyDataSource_name
=== RUN   TestAccNetworkFirewallFirewallPolicyDataSource_nameAndARN
=== PAUSE TestAccNetworkFirewallFirewallPolicyDataSource_nameAndARN
=== CONT  TestAccNetworkFirewallFirewallPolicyDataSource_arn
=== CONT  TestAccNetworkFirewallFirewallPolicyDataSource_nameAndARN
--- PASS: TestAccNetworkFirewallFirewallPolicyDataSource_nameAndARN (153.09s)
=== CONT  TestAccNetworkFirewallFirewallPolicyDataSource_name
--- PASS: TestAccNetworkFirewallFirewallPolicyDataSource_arn (153.15s)
--- PASS: TestAccNetworkFirewallFirewallPolicyDataSource_name (142.01s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/networkfirewall	299.418s

ewbankkit · 2022-07-08T13:54:04Z

@ddericco Thanks for the contribution 🎉 👏.

github-actions · 2022-07-22T03:01:47Z

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-08-22T02:41:34Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

ddericco marked this pull request as ready for review May 12, 2022 00:58

justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels May 12, 2022

ddericco requested a review from ewbankkit as a code owner June 20, 2022 12:44

drewmullen force-pushed the f-data-networkfirewall_firewall_policy branch from 5fd0431 to 21e5d13 Compare June 20, 2022 19:52

github-actions bot added the service/ec2 Issues and PRs that pertain to the ec2 service. label Jun 20, 2022

ddericco force-pushed the f-data-networkfirewall_firewall_policy branch from 21e5d13 to f9e7e47 Compare June 20, 2022 20:08

github-actions bot removed the service/ec2 Issues and PRs that pertain to the ec2 service. label Jun 20, 2022

Dave DeRicco added 11 commits June 20, 2022 16:09

First push to add Network Firewall data source

696b5fc

Add changelog, WIP support for name input

d8091e0

Add support, tests for name input

1abf27a

Acceptance tests for name + ARN input

a013968

Cleanup unneeded comments

13cc1f5

Fix issues with linting

7b70f07

First push to add Network Firewall data source

7f5fdaf

Add changelog, WIP support for name input

b4fac27

Acceptance tests for name + ARN input

5ced017

Cleanup unneeded comments

9a5db7e

Fix issues with linting

f045aae

ddericco force-pushed the f-data-networkfirewall_firewall_policy branch from f9e7e47 to f045aae Compare June 20, 2022 20:10

GlennChia self-requested a review June 27, 2022 14:10

Update acceptance tests, misc. fixes

80946f1

- Fix misc. formatting issues and clean up unneeded comments - Update acceptance tests to compare ARN from datasource and resource - Simplify debugging statements with `diag.Errorf()`

GlennChia suggested changes Jul 1, 2022

View reviewed changes

ddericco and others added 2 commits July 5, 2022 16:38

Apply suggestions from code review

1341022

Co-authored-by: Glenn <31919569+GlennChia@users.noreply.github.com>

Apply documentation recommendations from code review

d308880

GlennChia suggested changes Jul 6, 2022

View reviewed changes

Apply suggestions from second code review

7e0be60

GlennChia approved these changes Jul 6, 2022

View reviewed changes

ewbankkit added 6 commits July 8, 2022 09:18

d/aws_networkfirewall_firewall_policy: Add 'DataSource' to acceptance…

473d653

… test function names.

Fix semgrep 'caps2-in-func-name'.

ab810de

Fix semgrep 'test-config-funcs-correct-form'.

f79562b

Fix 'MD031/blanks-around-fences Fenced code blocks should be surround…

918874f

…ed by blank lines' and 'MD047/single-trailing-newline Files should end with a single newline character'.

Fix semgrep 'networkfirewall-in-test-name'.

edd467a

Fix terrafmt error.

1594b89

ewbankkit approved these changes Jul 8, 2022

View reviewed changes

ewbankkit merged commit 5539af2 into hashicorp:main Jul 8, 2022

github-actions bot added this to the v4.23.0 milestone Jul 8, 2022

ddericco deleted the f-data-networkfirewall_firewall_policy branch July 14, 2022 11:36

github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022

justinretzolk added the partner Contribution from a partner. label May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

f-data-networkfirewall_firewall_policy #24748

f-data-networkfirewall_firewall_policy #24748

ddericco commented May 11, 2022 •

edited

Loading

ddericco commented May 12, 2022

github-actions bot commented Jun 20, 2022

github-actions bot commented Jun 20, 2022

GlennChia left a comment

GlennChia left a comment

GlennChia left a comment

ddericco commented Jul 6, 2022 •

edited

Loading

ewbankkit left a comment

ewbankkit commented Jul 8, 2022

github-actions bot commented Jul 22, 2022

github-actions bot commented Aug 22, 2022

f-data-networkfirewall_firewall_policy #24748

f-data-networkfirewall_firewall_policy #24748

Conversation

ddericco commented May 11, 2022 • edited Loading

Community Note

ddericco commented May 12, 2022

github-actions bot commented Jun 20, 2022

github-actions bot commented Jun 20, 2022

GlennChia left a comment

Choose a reason for hiding this comment

GlennChia left a comment

Choose a reason for hiding this comment

GlennChia left a comment

Choose a reason for hiding this comment

ddericco commented Jul 6, 2022 • edited Loading

ewbankkit left a comment

Choose a reason for hiding this comment

ewbankkit commented Jul 8, 2022

github-actions bot commented Jul 22, 2022

github-actions bot commented Aug 22, 2022

ddericco commented May 11, 2022 •

edited

Loading

ddericco commented Jul 6, 2022 •

edited

Loading