Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping Metadata API check on S3 backend also skips in for the provider #24370

Closed
gdavison opened this issue Apr 22, 2022 · 2 comments · Fixed by #24441
Closed

Skipping Metadata API check on S3 backend also skips in for the provider #24370

gdavison opened this issue Apr 22, 2022 · 2 comments · Fixed by #24441
Milestone

Comments

@gdavison
Copy link
Contributor

From bug report:

If an S3 backend is initialized with skip_metadata_api_check=true, but a provider wants skip_metadata_api_check=false it will fail with EC2 IMDS access disabled via AWS_EC2_METADATA_DISABLED env var.

When the backend is initialized and sets the AWS_EC2_METADATA_DISABLED it sticks around and interferes with the provider's initialization of the SDK client.

skip_metadata_api_check currently only handles the true case, and a false value is ignored, therefore using the value of AWS_EC2_METADATA_DISABLED if set. skip_metadata_api_check should be updated so that false is treated as an actual state, using a nullable-boolean.

Reference: hashicorp/aws-sdk-go-base#240

@github-actions
Copy link

This functionality has been released in v4.12.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant