-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/transfer_workflow - new resource #24248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTS=TestAccTransferWorkflow_ PKG=transfer ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 3 -run='TestAccTransferWorkflow_' -timeout 180m
=== RUN TestAccTransferWorkflow_basic
--- PASS: TestAccTransferWorkflow_basic (17.00s)
=== RUN TestAccTransferWorkflow_onExecution
--- PASS: TestAccTransferWorkflow_onExecution (17.27s)
=== RUN TestAccTransferWorkflow_description
--- PASS: TestAccTransferWorkflow_description (16.18s)
=== RUN TestAccTransferWorkflow_tags
--- PASS: TestAccTransferWorkflow_tags (40.27s)
=== RUN TestAccTransferWorkflow_disappears
--- PASS: TestAccTransferWorkflow_disappears (11.84s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/transfer 106.374s
% make testacc TESTS=TestAccTransfer_serial/Server/basic PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransfer_serial/Server/basic' -timeout 180m
=== RUN TestAccTransfer_serial
=== RUN TestAccTransfer_serial/Server
=== RUN TestAccTransfer_serial/Server/basic
--- PASS: TestAccTransfer_serial (207.52s)
--- PASS: TestAccTransfer_serial/Server (207.52s)
--- PASS: TestAccTransfer_serial/Server/basic (207.52s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/transfer 211.125s
% make testacc TESTS=TestAccTransfer_serial/Server/Workflow PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransfer_serial/Server/Workflow' -timeout 180m
=== RUN TestAccTransfer_serial
=== RUN TestAccTransfer_serial/Server
=== RUN TestAccTransfer_serial/Server/Workflow
--- PASS: TestAccTransfer_serial (211.52s)
--- PASS: TestAccTransfer_serial/Server (211.52s)
--- PASS: TestAccTransfer_serial/Server/Workflow (211.52s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/transfer 214.987s
% make testacc TESTS=TestAccTransfer_serial/Server/VPCEndpointID PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransfer_serial/Server/VPCEndpointID' -timeout 180m
=== RUN TestAccTransfer_serial
=== RUN TestAccTransfer_serial/Server
=== RUN TestAccTransfer_serial/Server/VPCEndpointID
--- PASS: TestAccTransfer_serial (77.71s)
--- PASS: TestAccTransfer_serial/Server (77.71s)
--- PASS: TestAccTransfer_serial/Server/VPCEndpointID (77.70s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/transfer 81.161s
GovCloud
% make testacc TESTS=TestAccTransferWorkflow_ PKG=transfer ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 3 -run='TestAccTransferWorkflow_' -timeout 180m
=== RUN TestAccTransferWorkflow_basic
--- PASS: TestAccTransferWorkflow_basic (28.87s)
=== RUN TestAccTransferWorkflow_onExecution
--- PASS: TestAccTransferWorkflow_onExecution (19.03s)
=== RUN TestAccTransferWorkflow_description
--- PASS: TestAccTransferWorkflow_description (18.20s)
=== RUN TestAccTransferWorkflow_tags
--- PASS: TestAccTransferWorkflow_tags (45.43s)
=== RUN TestAccTransferWorkflow_disappears
--- PASS: TestAccTransferWorkflow_disappears (13.93s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/transfer 135.938s
% make testacc TESTS=TestAccTransfer_serial/Server/VPCEndpointID PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransfer_serial/Server/VPCEndpointID' -timeout 180m
=== RUN TestAccTransfer_serial
=== RUN TestAccTransfer_serial/Server
=== RUN TestAccTransfer_serial/Server/VPCEndpointID
acctest.go:681: skipping tests; current partition (aws-us-gov) not supported
--- PASS: TestAccTransfer_serial (1.51s)
--- PASS: TestAccTransfer_serial/Server (1.51s)
--- SKIP: TestAccTransfer_serial/Server/VPCEndpointID (1.51s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/transfer 5.088s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #21808
Output from acceptance testing: