-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add access_type
, customer_owned_ipv4_pool
arguments for aws_s3outposts_endpoint
#23839
Add access_type
, customer_owned_ipv4_pool
arguments for aws_s3outposts_endpoint
#23839
Conversation
access_type
, customer_owned_ipv4_pool
arguments for aws_s3out…access_type
, customer_owned_ipv4_pool
arguments for aws_s3outposts_endpoint
# Conflicts: # internal/service/s3outposts/endpoint.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccS3OutpostsEndpoint_' PKG=s3outposts ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3outposts/... -v -count 1 -parallel 2 -run=TestAccS3OutpostsEndpoint_ -timeout 180m
=== RUN TestAccS3OutpostsEndpoint_basic
=== PAUSE TestAccS3OutpostsEndpoint_basic
=== RUN TestAccS3OutpostsEndpoint_private
=== PAUSE TestAccS3OutpostsEndpoint_private
=== RUN TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
=== PAUSE TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
=== RUN TestAccS3OutpostsEndpoint_disappears
=== PAUSE TestAccS3OutpostsEndpoint_disappears
=== CONT TestAccS3OutpostsEndpoint_basic
=== CONT TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool
acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_customerOwnedIPv4Pool (1.05s)
=== CONT TestAccS3OutpostsEndpoint_disappears
=== CONT TestAccS3OutpostsEndpoint_basic
acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_basic (1.10s)
=== CONT TestAccS3OutpostsEndpoint_private
=== CONT TestAccS3OutpostsEndpoint_disappears
acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_disappears (0.18s)
=== CONT TestAccS3OutpostsEndpoint_private
acctest.go:1047: skipping since no Outposts found
--- SKIP: TestAccS3OutpostsEndpoint_private (0.20s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3outposts 6.927s
@suzusuzu Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #23834
Output from acceptance testing: