Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-source/iam_policy_document: Remove source_json and override_json #22906

Closed
anGie44 opened this issue Feb 2, 2022 · 3 comments · Fixed by #30829
Closed

data-source/iam_policy_document: Remove source_json and override_json #22906

anGie44 opened this issue Feb 2, 2022 · 3 comments · Fixed by #30829
Assignees
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope.
Milestone

Comments

@anGie44
Copy link
Contributor

anGie44 commented Feb 2, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

source_json and override_json were deprecated in v4.0 (#22890), thus should be removed in the next major milestone (v5.0)

Removing these arguments will impose a small burden on practitioners in updating their configurations. See below for an example of updating a configuration.

New or Affected Resource(s)

  • data-source/aws_iam_policy_document

Potential Terraform Configuration

Pre-deprecation

data "aws_iam_policy_document" "source_json_example" {
  source_json = data.aws_iam_policy_document.source.json
}

Post-deprecation

data "aws_iam_policy_document" "source_json_example" {
  source_policy_documents = [data.aws_iam_policy_document.source.json]
}

Reference:

@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. labels Feb 2, 2022
@anGie44 anGie44 added this to the v5.0.0 milestone Feb 2, 2022
@YakDriver YakDriver self-assigned this Apr 19, 2023
@github-actions github-actions bot modified the milestones: v5.0.0, v4.64.0 Apr 20, 2023
@YakDriver YakDriver modified the milestones: v4.64.0, v5.0.0 Apr 20, 2023
@jar-b
Copy link
Member

jar-b commented May 23, 2023

Closed by #30829, merged to main via #31392

@jar-b jar-b closed this as completed May 23, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants