Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RStudio support for SageMaker Domain #22789

Closed
dsturnbull opened this issue Jan 27, 2022 · 2 comments · Fixed by #31031
Closed

RStudio support for SageMaker Domain #22789

dsturnbull opened this issue Jan 27, 2022 · 2 comments · Fixed by #31031
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Milestone

Comments

@dsturnbull
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Support for specifying RStudio domain settings when creating via the aws_sagemaker_domain resource.

https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_CreateDomain.html

https://docs.aws.amazon.com/sdk-for-go/api/service/sagemaker/#DomainSettings

In the potential config below,

Specifying "rstudio_server_settings" enables the feature, assuming a licence is found.

default_user_settings's rstudio_settings configures the default user interaction with RStudio Pro server.

New or Affected Resource(s)

  • aws_sagemaker_domain

Potential Terraform Configuration

resource "aws_sagemaker_domain" "domain" {
  domain_name = "domain"
  auth_mode   = "IAM"
  vpc_id      = aws_vpc.vpc.id
  subnet_ids  = aws_subnet.public_subnets.*.id

  rstudio_server_settings = {
    domain_execution_role_arn = "..."
  }

  default_user_settings {
    execution_role = aws_iam_role.default_execution_role.arn
    rstudio_settings = {
      access_status  = "ENABLED"
      user_group     =  R_STUDIO_USER"
    }
  }
}
@dsturnbull dsturnbull added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 27, 2022
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Jan 27, 2022
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Feb 4, 2022
@github-actions github-actions bot added this to the v4.66.0 milestone Apr 28, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

This functionality has been released in v4.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants