Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_eks_node_group missing suspended_processes support like AZRebalance #21692

Open
devopsmash opened this issue Nov 9, 2021 · 4 comments
Open
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. upstream Addresses functionality related to the cloud provider.

Comments

@devopsmash
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

while the resource aws_autoscaling_group has suspended_processes like:

  suspended_processes = ["AZRebalance"]

The resource aws_eks_node_group doesn't support suspended_processes

It seems that the Managed Autoscale group has this option

image

Can you add this support for the resource aws_eks_node_group?

New or Affected Resource(s)

  • aws_eks_node_group
@devopsmash devopsmash added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 9, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/eks Issues and PRs that pertain to the eks service. labels Nov 9, 2021
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Nov 9, 2021
@Natalique
Copy link

Any updates on this maybe?
We've been experiencing some issues with Cluster autoscaler and AZRebalance

@naor919
Copy link

naor919 commented Aug 15, 2022

Same issue for me.

@eclivus
Copy link

eclivus commented Sep 22, 2022

I can't help you on coding it, but it I was able to do it with a null_resource command using
aws autoscaling suspend-processes --auto-scaling-group-name ${each.value} --scaling-processes AZRebalance
Auto scaling group names can be accessed through terraform-provider-aws module (I used a data source however for simplicity).

@mattburgess mattburgess added the upstream Addresses functionality related to the cloud provider. label Dec 6, 2022
@mattburgess
Copy link
Collaborator

Unfortunately, there's no support for passing down the desired suspended_processes through to the underlying ASG in the EKS API. Given that the underlying ASG isn't managed by Terraform, I think that @eclivus' suggestion is the best option right now. If anyone interested in this feature has a support contract with AWS it might be worth you trying to engage with your TAM to see if the feature can be put on the EKS backlog. There's a related roadmap item aws/containers-roadmap#1453 (with a similar null_resource workaround) which it might be worth folks tracking and/or providing input to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Development

No branches or pull requests

6 participants