Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support network_card_index in launch_template network_interfaces #21147

Closed
henighan opened this issue Oct 4, 2021 · 5 comments · Fixed by #21555
Closed

Support network_card_index in launch_template network_interfaces #21147

henighan opened this issue Oct 4, 2021 · 5 comments · Fixed by #21555
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@henighan
Copy link

henighan commented Oct 4, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS cloudformation's AWS::EC2::LaunchTemplate NetworkInterface supports a NetworkCardIndex parameter, which is distinct from the NetworkInterfaceID parameter.
I do not see a network_card_index argument in the terraform aws_launch_template's network_interfaces block (though there is a network_interface_id argument).
To see this in the documentation, please compare terraform launch_template network_interfaces to AWS::EC2::LaunchTemplate NetworkInterface.
Is network_card_index not currently supported, or am I being silly? How difficult/what steps would be required to add support for it?

New or Affected Resource(s)

  • aws_launch_template

Potential Terraform Configuration

N/A

References

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/launch_template#network-interfaces
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-launchtemplate-networkinterface.html

  • #0000
@henighan henighan added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 4, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. labels Oct 4, 2021
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 5, 2021
@AdamTylerLynch
Copy link
Collaborator

For clarification, when evaluating if an AWS Service supports a specific attribute, it is best to review the AWS API documentation, not the AWS CloudFormation documentation. While CloudFormation often mimics what the Service APIs have, it does not always.

The source of truth should always be the public API documentation.

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_LaunchTemplateInstanceNetworkInterfaceSpecificationRequest.html

@henighan
Copy link
Author

Thanks for the correction @AdamTylerLynch. Here's a description of the NetworkCardIndex copy-pasted from the above link:

NetworkCardIndex
The index of the network card. Some instance types support multiple network cards. The primary network interface must be assigned to network card index 0. The default is network card index 0.
Type: Integer
Required: No

@vara-bonthu
Copy link
Contributor

@justinretzolk I have raised a PR for this issue/feature. Please do let me know if you need more details.

@github-actions github-actions bot added this to the v3.64.0 milestone Nov 3, 2021
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This functionality has been released in v3.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
4 participants