Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource aws_kafkaconnect_connector #20942

Closed
bryantbiggs opened this issue Sep 17, 2021 · 13 comments · Fixed by #23544
Closed

New resource aws_kafkaconnect_connector #20942

bryantbiggs opened this issue Sep 17, 2021 · 13 comments · Fixed by #23544
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/kafka Issues and PRs that pertain to the kafka service.
Milestone

Comments

@bryantbiggs
Copy link
Contributor

bryantbiggs commented Sep 17, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add new resource for provisioning Kafka connectors - requires upgrading aws-sdk-go to at least v1.40.44

New or Affected Resource(s)

  • aws_kafkaconnect_connector

Potential Terraform Configuration

resources "aws_kafkaconnect_connector" "example" {
	capacity = "..."
	connector_configuration = "..."
	connector_description = "..."
	connector_name = "..."
	kafka_clsuter = "..."
	kafka_cluster_client_authentication = "..."
	kafka_cluster_encryption_in_transit = "..."
	kafka_connect_version = "..."
	log_delivery = "..."
	plugins = ["..."]
	service_execution_role_arn = "..."
	worker_configuration = "..."
	tags = "..."
}

References

@bryantbiggs bryantbiggs added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 17, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/kafka Issues and PRs that pertain to the kafka service. labels Sep 17, 2021
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 17, 2021
@ewbankkit
Copy link
Contributor

This new resource should likely be named aws_kafkaconnect_connector to match the underlying AWS API service ID.

@bryantbiggs bryantbiggs changed the title New resource aws_msk_connector New resource aws_kafkaconnect_connector Sep 20, 2021
This was referenced Sep 28, 2021
@gouline
Copy link

gouline commented Oct 12, 2021

Starting to look into implementing this. What's the thinking behind naming it aws_kafkaconnect_connector instead of keeping it consistent with existing aws_msk_cluster (whose underlying AWS API service ID is kafka) and going with aws_msk_connector or aws_mskconnect_connector?

@chadlagore
Copy link

Prefer aws_msk_connector as well.

@gouline do you have progress on this? We were also looking into spending time on it if necessary. It seems all the golang support is in place.

@limitusus
Copy link

Also I think we need aws_msk_worker_configuration and aws_msk_plugin as parameters for aws_msk_connector.

@clocklear
Copy link

Any progress to report on this resource? Happy to help out if necessary.

@chadlagore
Copy link

We won’t be working on this since we need a ConfigProvider and MSK connect doesn’t support it.

@rtim75
Copy link
Contributor

rtim75 commented Dec 22, 2021

I'm also starting to look into implementing this and ready to collaborate. Since the underlying API kafkaconnect is different from the kafka one which is represented as msk service, I think the aws_mskconnect_ fits perfectly.

@gdavison
Copy link
Contributor

Thanks for the supporting PRs, @rtim75. Are you still planning on implementing the aws_kafkaconnect_connector resource? If not, no worries.

@gdavison gdavison added the waiting-response Maintainers are waiting on response from community or contributor. label Jan 18, 2022
@rtim75
Copy link
Contributor

rtim75 commented Jan 19, 2022

@gdavison Yes, I'm writing kafkaconnect_connector in my free time. I can create a draft PR for it, if you'd like.

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Jan 19, 2022
@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@chrismowbraybv
Copy link

Hey @breathingdust, thanks for the update! is the Enhancements to Existing Services in priority order? if thats the case, I guess it would be more towards the end of the quarter for this feature?

@github-actions
Copy link

This functionality has been released in v4.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 5, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. service/kafka Issues and PRs that pertain to the kafka service.
Projects
None yet
10 participants