Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lambda function Zip type attribute checks #20575

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Fix lambda function Zip type attribute checks #20575

merged 3 commits into from
Aug 17, 2021

Conversation

tism
Copy link
Contributor

@tism tism commented Aug 16, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20574

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSLambdaFunction_zip_validation'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_zip_validation -timeout 180m
=== RUN   TestAccAWSLambdaFunction_zip_validation
=== PAUSE TestAccAWSLambdaFunction_zip_validation
=== CONT  TestAccAWSLambdaFunction_zip_validation
--- PASS: TestAccAWSLambdaFunction_zip_validation (8.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	11.522s

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/S Managed by automation to categorize the size of a PR. labels Aug 16, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 17, 2021
ewbankkit
ewbankkit approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSLambdaFunction_'                                      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_ -timeout 180m
=== RUN   TestAccAWSLambdaFunction_basic
=== PAUSE TestAccAWSLambdaFunction_basic
=== RUN   TestAccAWSLambdaFunction_UnpublishedCodeUpdate
=== PAUSE TestAccAWSLambdaFunction_UnpublishedCodeUpdate
=== RUN   TestAccAWSLambdaFunction_disappears
=== PAUSE TestAccAWSLambdaFunction_disappears
=== RUN   TestAccAWSLambdaFunction_codeSigningConfig
=== PAUSE TestAccAWSLambdaFunction_codeSigningConfig
=== RUN   TestAccAWSLambdaFunction_concurrency
=== PAUSE TestAccAWSLambdaFunction_concurrency
=== RUN   TestAccAWSLambdaFunction_concurrencyCycle
=== PAUSE TestAccAWSLambdaFunction_concurrencyCycle
=== RUN   TestAccAWSLambdaFunction_expectFilenameAndS3Attributes
=== PAUSE TestAccAWSLambdaFunction_expectFilenameAndS3Attributes
=== RUN   TestAccAWSLambdaFunction_envVariables
=== PAUSE TestAccAWSLambdaFunction_envVariables
=== RUN   TestAccAWSLambdaFunction_Environment_Variables_NoValue
=== PAUSE TestAccAWSLambdaFunction_Environment_Variables_NoValue
=== RUN   TestAccAWSLambdaFunction_encryptedEnvVariables
=== PAUSE TestAccAWSLambdaFunction_encryptedEnvVariables
=== RUN   TestAccAWSLambdaFunction_versioned
=== PAUSE TestAccAWSLambdaFunction_versioned
=== RUN   TestAccAWSLambdaFunction_versionedUpdate
=== PAUSE TestAccAWSLambdaFunction_versionedUpdate
=== RUN   TestAccAWSLambdaFunction_enablePublish
=== PAUSE TestAccAWSLambdaFunction_enablePublish
=== RUN   TestAccAWSLambdaFunction_disablePublish
=== PAUSE TestAccAWSLambdaFunction_disablePublish
=== RUN   TestAccAWSLambdaFunction_DeadLetterConfig
=== PAUSE TestAccAWSLambdaFunction_DeadLetterConfig
=== RUN   TestAccAWSLambdaFunction_DeadLetterConfigUpdated
=== PAUSE TestAccAWSLambdaFunction_DeadLetterConfigUpdated
=== RUN   TestAccAWSLambdaFunction_nilDeadLetterConfig
=== PAUSE TestAccAWSLambdaFunction_nilDeadLetterConfig
=== RUN   TestAccAWSLambdaFunction_FileSystemConfig
=== PAUSE TestAccAWSLambdaFunction_FileSystemConfig
=== RUN   TestAccAWSLambdaFunction_imageConfig
=== PAUSE TestAccAWSLambdaFunction_imageConfig
=== RUN   TestAccAWSLambdaFunction_tracingConfig
=== PAUSE TestAccAWSLambdaFunction_tracingConfig
=== RUN   TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables
=== PAUSE TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables
=== RUN   TestAccAWSLambdaFunction_Layers
=== PAUSE TestAccAWSLambdaFunction_Layers
=== RUN   TestAccAWSLambdaFunction_LayersUpdate
=== PAUSE TestAccAWSLambdaFunction_LayersUpdate
=== RUN   TestAccAWSLambdaFunction_VPC
=== PAUSE TestAccAWSLambdaFunction_VPC
=== RUN   TestAccAWSLambdaFunction_VPCRemoval
=== PAUSE TestAccAWSLambdaFunction_VPCRemoval
=== RUN   TestAccAWSLambdaFunction_VPCUpdate
=== PAUSE TestAccAWSLambdaFunction_VPCUpdate
=== RUN   TestAccAWSLambdaFunction_VPC_withInvocation
=== PAUSE TestAccAWSLambdaFunction_VPC_withInvocation
=== RUN   TestAccAWSLambdaFunction_VPC_publish_No_Changes
=== PAUSE TestAccAWSLambdaFunction_VPC_publish_No_Changes
=== RUN   TestAccAWSLambdaFunction_VPC_publish_Has_Changes
=== PAUSE TestAccAWSLambdaFunction_VPC_publish_Has_Changes
=== RUN   TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies
=== PAUSE TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies
=== RUN   TestAccAWSLambdaFunction_EmptyVpcConfig
=== PAUSE TestAccAWSLambdaFunction_EmptyVpcConfig
=== RUN   TestAccAWSLambdaFunction_s3
=== PAUSE TestAccAWSLambdaFunction_s3
=== RUN   TestAccAWSLambdaFunction_localUpdate
=== PAUSE TestAccAWSLambdaFunction_localUpdate
=== RUN   TestAccAWSLambdaFunction_localUpdate_nameOnly
=== PAUSE TestAccAWSLambdaFunction_localUpdate_nameOnly
=== RUN   TestAccAWSLambdaFunction_s3Update_basic
=== PAUSE TestAccAWSLambdaFunction_s3Update_basic
=== RUN   TestAccAWSLambdaFunction_s3Update_unversioned
=== PAUSE TestAccAWSLambdaFunction_s3Update_unversioned
=== RUN   TestAccAWSLambdaFunction_tags
=== PAUSE TestAccAWSLambdaFunction_tags
=== RUN   TestAccAWSLambdaFunction_runtimes
=== PAUSE TestAccAWSLambdaFunction_runtimes
=== RUN   TestAccAWSLambdaFunction_zip_validation
=== PAUSE TestAccAWSLambdaFunction_zip_validation
=== CONT  TestAccAWSLambdaFunction_basic
=== CONT  TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables
=== CONT  TestAccAWSLambdaFunction_localUpdate_nameOnly
=== CONT  TestAccAWSLambdaFunction_tags
=== CONT  TestAccAWSLambdaFunction_EmptyVpcConfig
=== CONT  TestAccAWSLambdaFunction_VPCUpdate
=== CONT  TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies
=== CONT  TestAccAWSLambdaFunction_VPC_publish_Has_Changes
=== CONT  TestAccAWSLambdaFunction_VPC_publish_No_Changes
=== CONT  TestAccAWSLambdaFunction_s3Update_basic
=== CONT  TestAccAWSLambdaFunction_VPC_withInvocation
=== CONT  TestAccAWSLambdaFunction_runtimes
=== CONT  TestAccAWSLambdaFunction_zip_validation
=== CONT  TestAccAWSLambdaFunction_versioned
=== CONT  TestAccAWSLambdaFunction_tracingConfig
=== CONT  TestAccAWSLambdaFunction_imageConfig
=== CONT  TestAccAWSLambdaFunction_FileSystemConfig
=== CONT  TestAccAWSLambdaFunction_nilDeadLetterConfig
=== CONT  TestAccAWSLambdaFunction_DeadLetterConfigUpdated
=== CONT  TestAccAWSLambdaFunction_s3Update_unversioned
=== CONT  TestAccAWSLambdaFunction_imageConfig
    resource_aws_lambda_function_test.go:925: AWS_LAMBDA_IMAGE_LATEST_ID, AWS_LAMBDA_IMAGE_V1_ID and AWS_LAMBDA_IMAGE_V2_ID env vars must be set for Lambda Container Image Support acceptance tests. 
--- SKIP: TestAccAWSLambdaFunction_imageConfig (0.84s)
=== CONT  TestAccAWSLambdaFunction_DeadLetterConfig
--- PASS: TestAccAWSLambdaFunction_zip_validation (13.75s)
=== CONT  TestAccAWSLambdaFunction_disablePublish
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (43.79s)
=== CONT  TestAccAWSLambdaFunction_enablePublish
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (84.45s)
=== CONT  TestAccAWSLambdaFunction_versionedUpdate
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (85.88s)
=== CONT  TestAccAWSLambdaFunction_concurrencyCycle
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (88.93s)
=== CONT  TestAccAWSLambdaFunction_encryptedEnvVariables
--- PASS: TestAccAWSLambdaFunction_disablePublish (81.78s)
=== CONT  TestAccAWSLambdaFunction_Environment_Variables_NoValue
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (97.22s)
=== CONT  TestAccAWSLambdaFunction_envVariables
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (116.38s)
=== CONT  TestAccAWSLambdaFunction_expectFilenameAndS3Attributes
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (17.18s)
=== CONT  TestAccAWSLambdaFunction_s3
--- PASS: TestAccAWSLambdaFunction_tags (169.96s)
=== CONT  TestAccAWSLambdaFunction_codeSigningConfig
--- PASS: TestAccAWSLambdaFunction_s3 (39.35s)
=== CONT  TestAccAWSLambdaFunction_VPCRemoval
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (303.12s)
=== CONT  TestAccAWSLambdaFunction_VPC
--- PASS: TestAccAWSLambdaFunction_runtimes (492.50s)
=== CONT  TestAccAWSLambdaFunction_LayersUpdate
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (496.11s)
=== CONT  TestAccAWSLambdaFunction_Layers
--- PASS: TestAccAWSLambdaFunction_tracingConfig (504.71s)
=== CONT  TestAccAWSLambdaFunction_concurrency
--- PASS: TestAccAWSLambdaFunction_versioned (873.79s)
=== CONT  TestAccAWSLambdaFunction_localUpdate
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (874.70s)
=== CONT  TestAccAWSLambdaFunction_disappears
--- PASS: TestAccAWSLambdaFunction_basic (882.06s)
=== CONT  TestAccAWSLambdaFunction_UnpublishedCodeUpdate
--- PASS: TestAccAWSLambdaFunction_VPC_publish_Has_Changes (897.72s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (1074.07s)
--- PASS: TestAccAWSLambdaFunction_Environment_Variables_NoValue (1006.32s)
--- PASS: TestAccAWSLambdaFunction_VPC_publish_No_Changes (1109.13s)
--- PASS: TestAccAWSLambdaFunction_enablePublish (1070.57s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (1043.60s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (1048.65s)
--- PASS: TestAccAWSLambdaFunction_envVariables (1092.20s)
--- PASS: TestAccAWSLambdaFunction_codeSigningConfig (1166.09s)
--- PASS: TestAccAWSLambdaFunction_Layers (1209.88s)
--- PASS: TestAccAWSLambdaFunction_VPC (1409.05s)
--- PASS: TestAccAWSLambdaFunction_concurrency (1228.17s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (1240.49s)
--- PASS: TestAccAWSLambdaFunction_disappears (858.48s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (873.47s)
--- PASS: TestAccAWSLambdaFunction_UnpublishedCodeUpdate (879.20s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (1761.58s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (2348.01s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (2403.24s)
--- PASS: TestAccAWSLambdaFunction_FileSystemConfig (2597.84s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       2601.418s

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Aug 17, 2021
@ewbankkit
Copy link
Contributor

@tism Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d529527 into hashicorp:main Aug 17, 2021
@github-actions github-actions bot added this to the v3.55.0 milestone Aug 17, 2021
@tism tism deleted the b-aws_lambda_function-zip_checks branch August 17, 2021 23:31
@github-actions
Copy link

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ewbankkit ewbankkit mentioned this pull request Aug 31, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
service/lambda Issues and PRs that pertain to the lambda service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.55.0
Development

Successfully merging this pull request may close these issues.

Lambda Zip function check only fails if both handler and runtime are missing
2 participants
@tism @ewbankkit