Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recovery control config resources #20568

Merged
merged 41 commits into from
Aug 24, 2021
Merged

Add recovery control config resources #20568

merged 41 commits into from
Aug 24, 2021

Conversation

ankita10051991
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20566

Output from acceptance testing:

TO-DO

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53recoverycontrolconfig Issues and PRs that pertain to the route53recoverycontrolconfig service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Aug 14, 2021
@ankita10051991 ankita10051991 mentioned this pull request Aug 19, 2021
Closed
@YakDriver YakDriver force-pushed the f-aws_route53_recovery_control_config_resources branch from a2ec723 to b387ebb Compare August 24, 2021 00:38
@YakDriver
Copy link
Member

Because the Meridian cluster limits are currently very low, I converted the tests to serial. When we get accounts and limits worked out, it would be great to change these back to parallel.

@ankita10051991
Copy link
Author

ankita10051991 commented Aug 24, 2021 •
edited
Loading

Because the Meridian cluster limits are currently very low, I converted the tests to serial. When we get accounts and limits worked out, it would be great to change these back to parallel.

We have default limit of 2 clusters for all accounts and I am not aware of any plans to change that. If there is a specific account id that you are using to run tests in parallel, I can get the limits increased for it tomorrow. Let me know

YakDriver
YakDriver approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

I made changes to get these working and bring them in alignment. Let me know if you have any questions.

Output from acceptance tests on us-west-2:

--- PASS: TestAccAWSRoute53RecoveryControlConfig_serial (753.90s)
    --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/Cluster (73.58s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/Cluster/basic (44.21s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/Cluster/disappears (29.37s)
    --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/ControlPanel (121.86s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/ControlPanel/basic (57.13s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/ControlPanel/disappears (64.73s)
    --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/RoutingControl (217.52s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/RoutingControl/nonDefaultControlPane (85.87s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/RoutingControl/basic (69.53s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/RoutingControl/disappears (62.12s)
    --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/SafetyRule (340.94s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/SafetyRule/assertionRule (106.92s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/SafetyRule/gatingRule (127.20s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/SafetyRule/disappears (106.82s)

Output from acceptance tests on GovCloud:

--- PASS: TestAccAWSRoute53RecoveryControlConfig_serial (1.53s)
    --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/Cluster (1.53s)
        --- SKIP: TestAccAWSRoute53RecoveryControlConfig_serial/Cluster/basic (1.53s)
        --- SKIP: TestAccAWSRoute53RecoveryControlConfig_serial/Cluster/disappears (0.00s)
    --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/ControlPanel (0.00s)
        --- SKIP: TestAccAWSRoute53RecoveryControlConfig_serial/ControlPanel/basic (0.00s)
        --- SKIP: TestAccAWSRoute53RecoveryControlConfig_serial/ControlPanel/disappears (0.00s)
    --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/RoutingControl (0.00s)
        --- SKIP: TestAccAWSRoute53RecoveryControlConfig_serial/RoutingControl/basic (0.00s)
        --- SKIP: TestAccAWSRoute53RecoveryControlConfig_serial/RoutingControl/disappears (0.00s)
        --- SKIP: TestAccAWSRoute53RecoveryControlConfig_serial/RoutingControl/nonDefaultControlPane (0.00s)
    --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/SafetyRule (0.00s)
        --- SKIP: TestAccAWSRoute53RecoveryControlConfig_serial/SafetyRule/gatingRule (0.00s)
        --- SKIP: TestAccAWSRoute53RecoveryControlConfig_serial/SafetyRule/disappears (0.00s)
        --- SKIP: TestAccAWSRoute53RecoveryControlConfig_serial/SafetyRule/assertionRule (0.00s)

@ankita10051991
Copy link
Author

Looks good! 🎉

I made changes to get these working and bring them in alignment. Let me know if you have any questions.

Output from acceptance tests on us-west-2:

--- PASS: TestAccAWSRoute53RecoveryControlConfig_serial (753.90s)
    --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/Cluster (73.58s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/Cluster/basic (44.21s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/Cluster/disappears (29.37s)
    --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/ControlPanel (121.86s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/ControlPanel/basic (57.13s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/ControlPanel/disappears (64.73s)
    --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/RoutingControl (217.52s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/RoutingControl/nonDefaultControlPane (85.87s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/RoutingControl/basic (69.53s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/RoutingControl/disappears (62.12s)
    --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/SafetyRule (340.94s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/SafetyRule/assertionRule (106.92s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/SafetyRule/gatingRule (127.20s)
        --- PASS: TestAccAWSRoute53RecoveryControlConfig_serial/SafetyRule/disappears (106.82s)

Awesome. Looks good to me. Thank you so much Dirk. Appreciate it

@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Aug 24, 2021
@YakDriver YakDriver added this to the v3.56.0 milestone Aug 24, 2021
@YakDriver YakDriver merged commit 9a7ca64 into hashicorp:main Aug 24, 2021
@github-actions
Copy link

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53recoverycontrolconfig Issues and PRs that pertain to the route53recoverycontrolconfig service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.56.0
Development

Successfully merging this pull request may close these issues.

Add support for Route53 Recovery Control Config resources
3 participants
@ankita10051991 @YakDriver @justinretzolk