Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource for AppStream Fleet #20543

Merged
merged 28 commits into from
Sep 22, 2021
Merged

Conversation

coderGo93
Copy link
Contributor

@coderGo93 coderGo93 commented Aug 12, 2021

Added a new resource, docs and tests for AppStream Fleet called aws_appstream_fleet

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #6508

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsAppStreamFleet'                                
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsAppStreamFleet -timeout 180m
=== RUN   TestAccAwsAppStreamFleet_basic
=== PAUSE TestAccAwsAppStreamFleet_basic
=== RUN   TestAccAwsAppStreamFleet_disappears
=== PAUSE TestAccAwsAppStreamFleet_disappears
=== RUN   TestAccAwsAppStreamFleet_completeWithStop
=== PAUSE TestAccAwsAppStreamFleet_completeWithStop
=== RUN   TestAccAwsAppStreamFleet_completeWithoutStop
=== PAUSE TestAccAwsAppStreamFleet_completeWithoutStop
=== RUN   TestAccAwsAppStreamFleet_withTags
=== PAUSE TestAccAwsAppStreamFleet_withTags
=== CONT  TestAccAwsAppStreamFleet_basic
=== CONT  TestAccAwsAppStreamFleet_completeWithoutStop
=== CONT  TestAccAwsAppStreamFleet_withTags
=== CONT  TestAccAwsAppStreamFleet_completeWithStop
=== CONT  TestAccAwsAppStreamFleet_disappears
--- PASS: TestAccAwsAppStreamFleet_disappears (746.95s)
--- PASS: TestAccAwsAppStreamFleet_basic (785.69s)
--- PASS: TestAccAwsAppStreamFleet_withTags (1419.06s)
--- PASS: TestAccAwsAppStreamFleet_completeWithoutStop (1800.00s)
--- PASS: TestAccAwsAppStreamFleet_completeWithStop (2630.85s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       2630.990s


@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appstream Issues and PRs that pertain to the appstream service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. labels Aug 12, 2021
@YakDriver YakDriver self-assigned this Aug 16, 2021
@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Aug 16, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderGo93 Overall, an excellent start to this resource! Thank you! Please see comments below.

aws/internal/service/appstream/finder/finder.go Outdated Show resolved Hide resolved
aws/resource_aws_appstream_fleet.go Outdated Show resolved Hide resolved
aws/resource_aws_appstream_fleet.go Outdated Show resolved Hide resolved
aws/resource_aws_appstream_fleet.go Outdated Show resolved Hide resolved
aws/resource_aws_appstream_fleet.go Outdated Show resolved Hide resolved
website/docs/r/appstream_fleet.html.markdown Outdated Show resolved Hide resolved
website/docs/r/appstream_fleet.html.markdown Outdated Show resolved Hide resolved
website/docs/r/appstream_fleet.html.markdown Outdated Show resolved Hide resolved
website/docs/r/appstream_fleet.html.markdown Outdated Show resolved Hide resolved
website/docs/r/appstream_fleet.html.markdown Outdated Show resolved Hide resolved
@YakDriver
Copy link
Member

This resource seems to be working fairly well. However, in acceptance testing, it seems to leave resources around. That combined with a lack of a sweeper is a bad combination. At this point, this needs 1. a sweeper, 2. debugging around why it's not destroying all resources - why tests aren't catching it...

Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

Subsequently, we need a sweeper and the waiter needs work for the unusual handling of errors on AWS side.

Output from acceptance tests (us-west-2):

--- PASS: TestAccAwsAppStreamFleet_basic (890.28s)
--- PASS: TestAccAwsAppStreamFleet_disappears (917.92s)
--- PASS: TestAccAwsAppStreamFleet_completeWithoutStop (936.91s)
--- PASS: TestAccAwsAppStreamFleet_withTags (958.20s)
--- PASS: TestAccAwsAppStreamFleet_completeWithStop (1775.73s)

--- PASS: TestAccAWSCodeStarConnectionsHost_vpcConfig (494.73s)
--- PASS: TestAccAWSDataSourceIAMGroup_basic (10.46s)
--- PASS: TestAccAWSDataSourceIAMRole_tags (10.57s)
--- PASS: TestAccAWSSQSQueuePolicy_basic (26.19s)

@github-actions github-actions bot added the service/secretsmanager Issues and PRs that pertain to the secretsmanager service. label Sep 22, 2021
@github-actions github-actions bot added service/codestarconnections Issues and PRs that pertain to the codestarconnections service. service/iam Issues and PRs that pertain to the iam service. service/sqs Issues and PRs that pertain to the sqs service. labels Sep 22, 2021
@YakDriver YakDriver added this to the v3.60.0 milestone Sep 22, 2021
@YakDriver YakDriver merged commit fe902a9 into hashicorp:main Sep 22, 2021
@github-actions
Copy link

This functionality has been released in v3.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/appstream Issues and PRs that pertain to the appstream service. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. service/iam Issues and PRs that pertain to the iam service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/sqs Issues and PRs that pertain to the sqs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants