Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_workteam #20122

Merged
merged 14 commits into from
Jul 28, 2021
Merged

r/sagemaker_workteam #20122

merged 14 commits into from
Jul 28, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jul 9, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #20065

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerWorkteam_'
--- PASS: TestAccAWSSagemakerWorkteam_cognitoConfig (182.70s)
--- PASS: TestAccAWSSagemakerWorkteam_oidcConfig (82.76s)
--- PASS: TestAccAWSSagemakerWorkteam_notificationConfig (94.64s)
--- PASS: TestAccAWSSagemakerWorkteam_disappears (28.50s)
--- PASS: TestAccAWSSagemakerWorkteam_tags (99.30s)

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/cognito service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 9, 2021
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Jul 10, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review July 10, 2021 18:40
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSSagemaker_serial/Workteam'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemaker_serial/Workteam -timeout 180m
=== RUN   TestAccAWSSagemaker_serial
=== RUN   TestAccAWSSagemaker_serial/Workteam
=== RUN   TestAccAWSSagemaker_serial/Workteam/Tags
=== RUN   TestAccAWSSagemaker_serial/Workteam/disappears
=== RUN   TestAccAWSSagemaker_serial/Workteam/CognitoConfig
=== RUN   TestAccAWSSagemaker_serial/Workteam/NotificationConfig
=== RUN   TestAccAWSSagemaker_serial/Workteam/OidcConfig
--- PASS: TestAccAWSSagemaker_serial (258.74s)
    --- PASS: TestAccAWSSagemaker_serial/Workteam (258.74s)
        --- PASS: TestAccAWSSagemaker_serial/Workteam/Tags (40.93s)
        --- PASS: TestAccAWSSagemaker_serial/Workteam/disappears (14.28s)
        --- PASS: TestAccAWSSagemaker_serial/Workteam/CognitoConfig (119.52s)
        --- PASS: TestAccAWSSagemaker_serial/Workteam/NotificationConfig (44.00s)
        --- PASS: TestAccAWSSagemaker_serial/Workteam/OidcConfig (40.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	262.534s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSSagemaker_serial/Workteam'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemaker_serial/Workteam -timeout 180m
=== RUN   TestAccAWSSagemaker_serial
=== RUN   TestAccAWSSagemaker_serial/Workteam
=== RUN   TestAccAWSSagemaker_serial/Workteam/disappears
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Workforce (tf-acc-test-3338485365894062168): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: b01a33c0-dd64-49e8-9113-0057fcdba9ee
        
          with aws_sagemaker_workforce.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_workforce" "test":
           2: resource "aws_sagemaker_workforce" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Workteam/CognitoConfig
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Workforce (tf-acc-test-3300705143379776796): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: a1a3f26f-253d-4308-aaca-6da868112d5d
        
          with aws_sagemaker_workforce.test,
          on terraform_plugin_test.tf line 22, in resource "aws_sagemaker_workforce" "test":
          22: resource "aws_sagemaker_workforce" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Workteam/NotificationConfig
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Workforce (tf-acc-test-5505759304734848796): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 5ffc7a4f-5485-47d9-b499-ad1f4333f7d3
        
          with aws_sagemaker_workforce.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_workforce" "test":
           2: resource "aws_sagemaker_workforce" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Workteam/OidcConfig
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Workforce (tf-acc-test-9213962711736425102): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: a45dca4a-8318-428d-b7b9-9aa790db7994
        
          with aws_sagemaker_workforce.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_workforce" "test":
           2: resource "aws_sagemaker_workforce" "test" {
        
=== RUN   TestAccAWSSagemaker_serial/Workteam/Tags
    provider_test.go:1147: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        
        Error: error creating SageMaker Workforce (tf-acc-test-6618553653401367899): UnknownOperationException: The requested operation is not supported in the called region.
        	status code: 400, request id: 806a22a9-e85b-4ef3-b92a-347a9709750a
        
          with aws_sagemaker_workforce.test,
          on terraform_plugin_test.tf line 2, in resource "aws_sagemaker_workforce" "test":
           2: resource "aws_sagemaker_workforce" "test" {
        
--- PASS: TestAccAWSSagemaker_serial (42.30s)
    --- PASS: TestAccAWSSagemaker_serial/Workteam (42.30s)
        --- SKIP: TestAccAWSSagemaker_serial/Workteam/disappears (7.29s)
        --- SKIP: TestAccAWSSagemaker_serial/Workteam/CognitoConfig (14.01s)
        --- SKIP: TestAccAWSSagemaker_serial/Workteam/NotificationConfig (9.73s)
        --- SKIP: TestAccAWSSagemaker_serial/Workteam/OidcConfig (5.73s)
        --- SKIP: TestAccAWSSagemaker_serial/Workteam/Tags (5.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.321s

@ewbankkit ewbankkit merged commit 280fc23 into hashicorp:main Jul 28, 2021
@github-actions github-actions bot added this to the v3.52.0 milestone Jul 28, 2021
@DrFaust92 DrFaust92 deleted the sagemaker_workteam branch July 28, 2021 20:00
@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants