Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ecs _cluster - add configuration block + refactor to user finder and waiters package #19785

Merged
merged 11 commits into from
Jun 14, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 14, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18334.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEcsCluster_'
--- PASS: TestAccAWSEcsCluster_disappears (40.63s)
--- PASS: TestAccAWSEcsCluster_basic (50.59s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (76.15s)
--- PASS: TestAccAWSEcsCluster_Tags (95.17s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (95.57s)
--- PASS: TestAccAWSEcsCluster_configuration (103.91s)
--- PASS: TestAccAWSEcsCluster_containerInsights (112.43s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (129.26s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (143.15s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner June 14, 2021 07:34
@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Jun 14, 2021
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 14, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 14, 2021
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
@ewbankkit ewbankkit self-assigned this Jun 14, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsCluster_'           
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsCluster_ -timeout 180m
=== RUN   TestAccAWSEcsCluster_basic
=== PAUSE TestAccAWSEcsCluster_basic
=== RUN   TestAccAWSEcsCluster_disappears
=== PAUSE TestAccAWSEcsCluster_disappears
=== RUN   TestAccAWSEcsCluster_Tags
=== PAUSE TestAccAWSEcsCluster_Tags
=== RUN   TestAccAWSEcsCluster_SingleCapacityProvider
=== PAUSE TestAccAWSEcsCluster_SingleCapacityProvider
=== RUN   TestAccAWSEcsCluster_CapacityProviders
=== PAUSE TestAccAWSEcsCluster_CapacityProviders
=== RUN   TestAccAWSEcsCluster_CapacityProvidersUpdate
=== PAUSE TestAccAWSEcsCluster_CapacityProvidersUpdate
=== RUN   TestAccAWSEcsCluster_CapacityProvidersNoStrategy
=== PAUSE TestAccAWSEcsCluster_CapacityProvidersNoStrategy
=== RUN   TestAccAWSEcsCluster_containerInsights
=== PAUSE TestAccAWSEcsCluster_containerInsights
=== RUN   TestAccAWSEcsCluster_configuration
=== PAUSE TestAccAWSEcsCluster_configuration
=== CONT  TestAccAWSEcsCluster_basic
=== CONT  TestAccAWSEcsCluster_CapacityProvidersUpdate
=== CONT  TestAccAWSEcsCluster_SingleCapacityProvider
=== CONT  TestAccAWSEcsCluster_CapacityProviders
=== CONT  TestAccAWSEcsCluster_configuration
=== CONT  TestAccAWSEcsCluster_containerInsights
=== CONT  TestAccAWSEcsCluster_CapacityProvidersNoStrategy
=== CONT  TestAccAWSEcsCluster_disappears
=== CONT  TestAccAWSEcsCluster_Tags
--- PASS: TestAccAWSEcsCluster_disappears (24.45s)
--- PASS: TestAccAWSEcsCluster_basic (27.26s)
--- PASS: TestAccAWSEcsCluster_Tags (46.39s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (49.02s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (53.20s)
--- PASS: TestAccAWSEcsCluster_configuration (53.92s)
--- PASS: TestAccAWSEcsCluster_containerInsights (63.10s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (81.81s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (97.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	100.935s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsCluster_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsCluster_ -timeout 180m
=== RUN   TestAccAWSEcsCluster_basic
=== PAUSE TestAccAWSEcsCluster_basic
=== RUN   TestAccAWSEcsCluster_disappears
=== PAUSE TestAccAWSEcsCluster_disappears
=== RUN   TestAccAWSEcsCluster_Tags
=== PAUSE TestAccAWSEcsCluster_Tags
=== RUN   TestAccAWSEcsCluster_SingleCapacityProvider
=== PAUSE TestAccAWSEcsCluster_SingleCapacityProvider
=== RUN   TestAccAWSEcsCluster_CapacityProviders
=== PAUSE TestAccAWSEcsCluster_CapacityProviders
=== RUN   TestAccAWSEcsCluster_CapacityProvidersUpdate
=== PAUSE TestAccAWSEcsCluster_CapacityProvidersUpdate
=== RUN   TestAccAWSEcsCluster_CapacityProvidersNoStrategy
=== PAUSE TestAccAWSEcsCluster_CapacityProvidersNoStrategy
=== RUN   TestAccAWSEcsCluster_containerInsights
=== PAUSE TestAccAWSEcsCluster_containerInsights
=== RUN   TestAccAWSEcsCluster_configuration
=== PAUSE TestAccAWSEcsCluster_configuration
=== CONT  TestAccAWSEcsCluster_basic
=== CONT  TestAccAWSEcsCluster_CapacityProvidersUpdate
=== CONT  TestAccAWSEcsCluster_Tags
=== CONT  TestAccAWSEcsCluster_disappears
=== CONT  TestAccAWSEcsCluster_containerInsights
=== CONT  TestAccAWSEcsCluster_CapacityProvidersNoStrategy
=== CONT  TestAccAWSEcsCluster_configuration
=== CONT  TestAccAWSEcsCluster_CapacityProviders
=== CONT  TestAccAWSEcsCluster_SingleCapacityProvider
--- PASS: TestAccAWSEcsCluster_disappears (28.08s)
--- PASS: TestAccAWSEcsCluster_basic (34.10s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (57.16s)
--- PASS: TestAccAWSEcsCluster_Tags (58.03s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (59.41s)
--- PASS: TestAccAWSEcsCluster_configuration (61.74s)
--- PASS: TestAccAWSEcsCluster_containerInsights (76.23s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (83.11s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (101.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	105.047s

@ewbankkit ewbankkit merged commit 176f8d2 into hashicorp:main Jun 14, 2021
@github-actions github-actions bot added this to the v3.46.0 milestone Jun 14, 2021
@DrFaust92 DrFaust92 deleted the r/ecs_cluster_config branch June 15, 2021 06:06
@github-actions
Copy link

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Amazon ECS Exec settings on ECS cluster and service resources
2 participants