AWS missing "pseudo" parameters

[rbirkby]

Terraform v0.10.7

data_source_aws_partition.go implements the aws "partition" pseudo parameters. However, other pseudo parameters are missing. For example, URLSuffix - which is correlated to the partition - is not available within terraform.

For details of this and other pseudo parameters, see the CloudFormation documentation

[lorengordon]

There are already data sources to get the partition, the current region, and the account ID. URL Suffix is missing. The remaining pseudo parameters appear to be related specifically to CloudFormation and the stack in question.

I can take a stab at implementing an equivalent of URLSuffix. Would it be preferable as a new data source, or a new attribute of data_source_aws_partition?

[lorengordon]

Heh, so, slightly annoying. I'm not finding an API call that returns the URL Suffix. And CloudFormation isn't open source, so can't really see how they do it. Can maybe parse it out of an endpoint, but which endpoint?

Looking at the other related data sources for inspiration...

• data_source_aws_partition gets the partition from the AWSClient struct, which is setup in config.go, where a few different methods are used to determine the partition
• data_source_aws_caller_identity gets the account_id from an API call to sts.GetCallerIdentity() (even though accountid is an attribute in the AWSClient struct? odd...)
• data_source_aws_region gets the current region from the AWSClient struct, which gets it from the Config struct, which gets it from the provider

[lorengordon]

Alright, got a first stab done, see #5602.

[bflad]

Support for a new dns_suffix attribute in the aws_partition data source has been merged and will release with version 2.23.0 of the Terraform AWS Provider in the next day or two. Thanks to @lorengordon for the implementation. 👍

[ghost]

This has been released in version 2.23.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!