Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aws_cloudwatch_metric_stream #18870

Closed
wants to merge 3 commits into from
Closed

Add support for aws_cloudwatch_metric_stream #18870

wants to merge 3 commits into from

Conversation

gcacace
Copy link
Contributor

@gcacace gcacace commented Apr 14, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18525

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCloudWatchMetricStream'

TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchMetricStream -timeout 180m
=== RUN   TestAccAWSCloudWatchMetricStream_basic
=== PAUSE TestAccAWSCloudWatchMetricStream_basic
=== RUN   TestAccAWSCloudWatchMetricStream_noName
=== PAUSE TestAccAWSCloudWatchMetricStream_noName
=== RUN   TestAccAWSCloudWatchMetricStream_namePrefix
=== PAUSE TestAccAWSCloudWatchMetricStream_namePrefix
=== RUN   TestAccAWSCloudWatchMetricStream_includeFilters
=== PAUSE TestAccAWSCloudWatchMetricStream_includeFilters
=== RUN   TestAccAWSCloudWatchMetricStream_excludeFilters
=== PAUSE TestAccAWSCloudWatchMetricStream_excludeFilters
=== RUN   TestAccAWSCloudWatchMetricStream_update
=== PAUSE TestAccAWSCloudWatchMetricStream_update
=== RUN   TestAccAWSCloudWatchMetricStream_updateName
=== PAUSE TestAccAWSCloudWatchMetricStream_updateName
=== CONT  TestAccAWSCloudWatchMetricStream_basic
=== CONT  TestAccAWSCloudWatchMetricStream_update
=== CONT  TestAccAWSCloudWatchMetricStream_excludeFilters
=== CONT  TestAccAWSCloudWatchMetricStream_namePrefix
=== CONT  TestAccAWSCloudWatchMetricStream_includeFilters
=== CONT  TestAccAWSCloudWatchMetricStream_noName
=== CONT  TestAccAWSCloudWatchMetricStream_updateName
--- PASS: TestAccAWSCloudWatchMetricStream_excludeFilters (35.26s)
--- PASS: TestAccAWSCloudWatchMetricStream_includeFilters (35.35s)
--- PASS: TestAccAWSCloudWatchMetricStream_noName (35.40s)
--- PASS: TestAccAWSCloudWatchMetricStream_namePrefix (37.61s)
--- PASS: TestAccAWSCloudWatchMetricStream_basic (111.76s)
--- PASS: TestAccAWSCloudWatchMetricStream_update (125.37s)
--- PASS: TestAccAWSCloudWatchMetricStream_updateName (191.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	193.508s

@gcacace gcacace requested a review from a team as a code owner April 14, 2021 23:41
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 14, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 14, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @gcacace 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Apr 15, 2021
@YakDriver YakDriver added service/cloudwatch Issues and PRs that pertain to the cloudwatch service. and removed needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. labels Apr 16, 2021
@YakDriver
Copy link
Member

@gcacace After a quick scan, this PR is looking good. Overall, the neatness and completeness, with implementation, docs, tests, is great! Thank you for submitting it! I may point out a few minor items. Also, I encourage you to check the "allow edits by maintainers" box to facilitate getting this merged more quickly.

@YakDriver YakDriver self-assigned this Apr 16, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your time on this!

aws/resource_aws_cloudwatch_metric_stream.go Show resolved Hide resolved
aws/resource_aws_cloudwatch_metric_stream.go Outdated Show resolved Hide resolved
aws/resource_aws_cloudwatch_metric_stream.go Outdated Show resolved Hide resolved
aws/resource_aws_cloudwatch_metric_stream.go Outdated Show resolved Hide resolved
aws/resource_aws_cloudwatch_metric_stream.go Outdated Show resolved Hide resolved
website/docs/r/cloudwatch_metric_stream.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cloudwatch_metric_stream.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cloudwatch_metric_stream.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cloudwatch_metric_stream.html.markdown Outdated Show resolved Hide resolved
website/docs/r/cloudwatch_metric_stream.html.markdown Outdated Show resolved Hide resolved
Co-authored-by: Dirk Avery <31492422+YakDriver@users.noreply.github.com>
@ghost ghost added the provider Pertains to the provider itself, rather than any interaction with AWS. label Apr 16, 2021
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Apr 17, 2021
@gcacace gcacace requested a review from YakDriver April 17, 2021 06:52
@gcacace
Copy link
Contributor Author

gcacace commented Apr 19, 2021

Hi @YakDriver, wondering if I've missed anything here apart from your comments that I've addressed in the latest revision.

@frankreno
Copy link

Hi Folks, is there any eta on when this will be merged, released, and supported by TF? This is a great add we are ourselves waiting on.

@gcacace
Copy link
Contributor Author

gcacace commented May 5, 2021

@YakDriver it has been almost 20 days since I've replied and fixed all the review comments. Is there any chance we can get this merged?

ismith added a commit to honeycombio/terraform-aws-honeycomb-cloudwatch-metric-stream that referenced this pull request May 13, 2021
… honeycomb

Things we need:
1. hashicorp/terraform-provider-aws#18870 to be merged (ismith is subscribed to this PR)
2. To test the module - sandbox account should be fine, we don't need anything complex here that'd require putting it in dogfood or terraform cloud
  - This includes testing the include_filters/exclude_filters variables
3. Documentarion in README.md
4. Documentation strings in variables.tf
5. version.tf needs a version for hashicorp/aws, and we should consider loosening the terraform.required_version constraint
6. Decide/document a release process (tl;dr: semver tags in github)

**Asana:**
https://app.asana.com/0/1199917178609623/1200319907426032
@YakDriver
Copy link
Member

@gcacace I was unable to push to your branch to fix remaining issues. I'm not sure if you "allow edits by maintainers" or if it fails because your branch name is "main." It is best to name branches following the convention of f- prefix for features, like a new resource (d- for docs, td- for technical debt, b- for bugs). One thing I notice that you'll need is to add, since the resource has tags, is the default tags capability. All resources should now have them. You can find examples in any resource with tags. Fixes needed for default tags:

  1. tags_all addition to schema
  2. Create: defaultTagsConfig addition, calculate tags var with MergeTags(), tags.IgnoreAWS()...
  3. Read: defaultTagsConfig, ignoreTagsConfig additions, if err := d.Set("tags"..., if err := d.Set("tags_all"...
  4. Update: if d.HasChang("tags_all")...

@YakDriver YakDriver added the waiting-response Maintainers are waiting on response from community or contributor. label May 18, 2021
@YakDriver
Copy link
Member

This will be superceded by #19429

@github-actions github-actions bot added this to the v3.41.0 milestone May 19, 2021
ismith added a commit to honeycombio/terraform-aws-honeycomb-cloudwatch-metric-stream that referenced this pull request May 21, 2021
…am resource

See: hashicorp/terraform-provider-aws#19429
(which superseded
hashicorp/terraform-provider-aws#18870).  Which
means we can remove all the clunky run-your-own-forked-provider junk.
Yay!
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2021
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amazon CloudWatch Metric Streams
6 participants