resource/aws_xray_sampling_rule fix rule name max length

[czubocha]

The maximum length of the X-Ray rule name is 32 chars according to AWS documentation. Currently, the validation is set to a maximum of 128 which causes 400 HTTP status code to be returned from AWS when provided name is longer than 32.

Error: error creating XRay Sampling Rule: ValidationException: 
	status code: 400, request id: xxxxx

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSXraySamplingRule_ -timeout 180m
=== RUN   TestAccAWSXraySamplingRule_basic
=== PAUSE TestAccAWSXraySamplingRule_basic
=== RUN   TestAccAWSXraySamplingRule_update
=== PAUSE TestAccAWSXraySamplingRule_update
=== RUN   TestAccAWSXraySamplingRule_tags
=== PAUSE TestAccAWSXraySamplingRule_tags
=== RUN   TestAccAWSXraySamplingRule_disappears
=== PAUSE TestAccAWSXraySamplingRule_disappears
=== CONT  TestAccAWSXraySamplingRule_basic
=== CONT  TestAccAWSXraySamplingRule_disappears
=== CONT  TestAccAWSXraySamplingRule_tags
=== CONT  TestAccAWSXraySamplingRule_update
--- PASS: TestAccAWSXraySamplingRule_disappears (16.97s)
--- PASS: TestAccAWSXraySamplingRule_basic (21.84s)
--- PASS: TestAccAWSXraySamplingRule_update (34.63s)
--- PASS: TestAccAWSXraySamplingRule_tags (48.29s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       50.320s

[github-actions]

Welcome @czubocha 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[anGie44]

Looks great @czubocha , thank you for this fix 🚀 !

Output of acceptance tests (Commercial):

--- PASS: TestAccAWSXraySamplingRule_disappears (11.37s)
--- PASS: TestAccAWSXraySamplingRule_basic (16.03s)
--- PASS: TestAccAWSXraySamplingRule_update (25.02s)
--- PASS: TestAccAWSXraySamplingRule_tags (34.49s)

[ghost]

This has been released in version 3.36.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!