Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_appmesh_virtual_node: Support mutual TLS authentication #18127

Merged

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #17481.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh_serial/VirtualNode'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh_serial/VirtualNode -timeout 180m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTls
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaultsCertificate
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerValidation
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/disappears
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaults
--- PASS: TestAccAWSAppmesh_serial (544.67s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (544.67s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (102.13s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (28.79s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (41.77s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (16.61s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile (29.12s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (29.26s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTls (72.96s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaultsCertificate (17.21s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (28.92s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (29.14s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerValidation (28.98s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (30.13s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (13.07s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm (56.67s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (28.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	544.783s

@ewbankkit ewbankkit requested a review from a team as a code owner March 16, 2021 19:14
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/appmesh Issues and PRs that pertain to the appmesh service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 16, 2021
@ewbankkit ewbankkit changed the title r/aws_appmesh_virtual_node: Support mutual TLS authentication [WIP] r/aws_appmesh_virtual_node: Support mutual TLS authentication Mar 16, 2021
@ewbankkit ewbankkit changed the title [WIP] r/aws_appmesh_virtual_node: Support mutual TLS authentication r/aws_appmesh_virtual_node: Support mutual TLS authentication Mar 16, 2021
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSAppmesh_serial (1270.44s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (1270.44s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (82.96s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTls (181.97s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (114.47s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (32.03s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm (118.75s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (156.02s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (70.81s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerValidation (72.45s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (44.84s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (70.68s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (70.13s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (68.90s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (72.70s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile (71.93s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaultsCertificate (41.81s)

@DrFaust92 DrFaust92 removed their assignment Mar 18, 2021
Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh_serial/VirtualNode'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh_serial/VirtualNode -timeout 180m
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTls
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaultsCertificate
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerValidation
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/disappears
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaults
--- PASS: TestAccAWSAppmesh_serial (544.67s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (544.67s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (102.13s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (28.79s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (41.77s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (16.61s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile (29.12s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (29.26s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTls (72.96s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaultsCertificate (17.21s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (28.92s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (29.14s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerValidation (28.98s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (30.13s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (13.07s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm (56.67s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (28.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	544.783s
@ewbankkit ewbankkit force-pushed the f-aws_appmesh_virtual_node-mutual-tls branch from 5b0223f to 2878bd8 Compare March 20, 2021 21:35
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @ewbankkit!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAppmesh_serial/VirtualNode'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmesh_serial/VirtualNode -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.38.0
=== RUN   TestAccAWSAppmesh_serial
=== RUN   TestAccAWSAppmesh_serial/VirtualNode
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaults
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerTls
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/listenerValidation
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/tags
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/basic
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/disappears
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/backendDefaultsCertificate
=== RUN   TestAccAWSAppmesh_serial/VirtualNode/logging
--- PASS: TestAccAWSAppmesh_serial (498.96s)
    --- PASS: TestAccAWSAppmesh_serial/VirtualNode (498.96s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaults (27.08s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/cloudMapServiceDiscovery (115.27s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerOutlierDetection (25.25s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerHealthChecks (25.09s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTimeout (24.80s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyFile (24.03s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerConnectionPool (24.97s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerTls (62.66s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/listenerValidation (24.08s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/tags (36.53s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/basic (13.77s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/disappears (11.17s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendClientPolicyAcm (46.08s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/backendDefaultsCertificate (13.99s)
        --- PASS: TestAccAWSAppmesh_serial/VirtualNode/logging (24.19s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	501.717s

@breathingdust breathingdust merged commit ce9d6c7 into hashicorp:main Mar 31, 2021
@github-actions github-actions bot added this to the v3.35.0 milestone Mar 31, 2021
@ewbankkit ewbankkit deleted the f-aws_appmesh_virtual_node-mutual-tls branch April 1, 2021 11:28
@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 1, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/appmesh Issues and PRs that pertain to the appmesh service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants